From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
gregkh@linuxfoundation.org, mturquette@baylibre.com,
sboyd@kernel.org, quic_wcheng@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v10 8/9] arm64: dts: qcom: ipq9574: Add LDO regulator node
Date: Sat, 6 May 2023 14:33:11 +0300 [thread overview]
Message-ID: <CAA8EJpqg2htfa2QZ7q6SP58N5YAABa8knBn4c5eYqYOU6HQNiA@mail.gmail.com> (raw)
In-Reply-To: <20230506110918.GC10918@varda-linux.qualcomm.com>
On Sat, 6 May 2023 at 14:09, Varadarajan Narayanan
<quic_varada@quicinc.com> wrote:
>
> On Fri, May 05, 2023 at 12:29:54PM +0300, Dmitry Baryshkov wrote:
> > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan
> > <quic_varada@quicinc.com> wrote:
> > >
> > > Add LDO regulator node
> >
> > As this LDO is provided by the PMIC, it would be nice to know why it
> > is modelled as an always-on regulator instead of the proper PMIC
> > regulator. Up to now we were doing this only for the outstanding power
> > rails like CX/MX or EBI.
>
> These are always ON because USB phy doesn't support power
> collapse, and there is a chance that other IP blocks might be
> sharing the rail.
You are describing the software side here. From the hardware point of
view, it is an I2C regulator, which is probably also exported as an
SMD_RPM regulator. Unless you have a good reason not to do so, there
should be a node under rpm-requests, which describes mp5496 regulators
exported via RPM. then USB should refer to those regulators.
>
> Thanks
> Varada
>
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > > ---
> > > Changes in v10:
> > > - Add LDO regulator node
> > > ---
> > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> > > index bdc1434..1f5d14f 100644
> > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> > > @@ -60,6 +60,13 @@
> > > regulator-min-microvolt = <725000>;
> > > regulator-max-microvolt = <1075000>;
> > > };
> > > +
> > > + mp5496_l2: l2 {
> > > + regulator-min-microvolt = <1800000>;
> > > + regulator-max-microvolt = <1800000>;
> > > + regulator-boot-on;
> > > + regulator-always-on;
> > > + };
> > > };
> > > };
> > >
> > > --
> > > 2.7.4
> > >
> >
> >
> > --
> > With best wishes
> > Dmitry
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-05-06 11:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 7:35 [PATCH v10 0/9] Enable IPQ9754 USB Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 1/9] dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 2/9] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY Varadarajan Narayanan
2023-05-05 17:46 ` Krzysztof Kozlowski
2023-05-05 7:35 ` [PATCH v10 3/9] dt-bindings: usb: dwc3: Add IPQ9574 compatible Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 4/9] clk: qcom: gcc-ipq9574: Add USB related clocks Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 5/9] phy: qcom-qusb2: add QUSB2 support for IPQ9574 Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 6/9] phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence Varadarajan Narayanan
2023-05-05 9:20 ` Dmitry Baryshkov
2023-05-05 7:35 ` [PATCH v10 7/9] arm64: dts: qcom: ipq9574: Add USB related nodes Varadarajan Narayanan
2023-05-05 9:31 ` Dmitry Baryshkov
2023-05-05 10:19 ` Varadarajan Narayanan
2023-05-05 7:35 ` [PATCH v10 8/9] arm64: dts: qcom: ipq9574: Add LDO regulator node Varadarajan Narayanan
2023-05-05 9:29 ` Dmitry Baryshkov
2023-05-05 19:26 ` Konrad Dybcio
2023-05-06 11:07 ` Dmitry Baryshkov
2023-05-06 11:09 ` Varadarajan Narayanan
2023-05-06 11:33 ` Dmitry Baryshkov [this message]
2023-05-08 5:16 ` Varadarajan Narayanan
2023-05-08 11:21 ` Dmitry Baryshkov
2023-05-05 7:35 ` [PATCH v10 9/9] arm64: dts: qcom: ipq9574: Enable USB Varadarajan Narayanan
2023-05-05 9:24 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpqg2htfa2QZ7q6SP58N5YAABa8knBn4c5eYqYOU6HQNiA@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).