From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7F71C2DB3 for ; Fri, 13 Sep 2024 11:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726227860; cv=none; b=rm+0ndZpYVikLE12ontGPgpXv3MHs+3EJSZNyQft0b9eYo15MkTSkRjWzekcD6dePcfpOzJnc4EQ7sxxj13dP/TvVEEPb/l0ne6sko3oWMOHq1VRdEr6NoKw7Cf4EiqzgQ2P2wCbszYuxZ5fZbsJ4qU33TokNkm7fEoxHwfECEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726227860; c=relaxed/simple; bh=WVlZCBI9rR2tjRj8gt8fXMMXF7h6R8iX/uuUUMIMVB8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=alMk059qlAikQecO7RwOagfOTmriOYaDGLb+rD4esHw2B+AY7TvXM/EgIRfZ+gK0d88lQoUI6gJrorFveDXgp16b6+lOSOiOeLHSi6U191DMwIuB7XgkazM+fbAypISA7PG3Usa47pgMamGS6XbmtMzEcVv1uLiNRaPUuo8sTPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=btETFu/e; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="btETFu/e" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-68518bc1407so8260627b3.2 for ; Fri, 13 Sep 2024 04:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726227857; x=1726832657; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bpGVAz7F68gq4K0wsGbVi84hQs0Zw4wJBgelJinUR+M=; b=btETFu/eJkaWeaPR4uNkeJRV3qiNNP2xq8PaYYDqHkY1Moy2uAaYuVyB9F+XRXX6bs RbOdB/Yvyj4CVE1GMyWmbHANPUnpsy1Z0d5tBtNHqclHvaYofO7t7wb118hgGfkvipQp /OtNq04hLtp4P5oZ2xNU8/QiSn8vS57lIB8mBaBFMg1ZNGC8/lGg+6UA2bi9z/lACDrK IfT0AS0WXLbilyN44jO/vnV9tl3pg3gge//J07idEmv1ecMqPSXBtQKSm+39/XXIw5Ou axC9lgFoUphFrImX0rsLcaGB7my3oQpET+7mztrehV7E8QQvkEFuntzobZBZaaUvFMQC nf+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726227857; x=1726832657; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bpGVAz7F68gq4K0wsGbVi84hQs0Zw4wJBgelJinUR+M=; b=r1ALqvVSOryuxbjdCUVfEjpHCTPMQToMp7/3oSXYJqTFhLHAlId/tLpFaE1WfyVGHj rh11HQloeEfqyTBOmeJgxjAN5PhMmAyjhKaaZKRfbXMofe/LCc8V4OfKYG4Xfb10g6kH O+5Y/nKWt75PvFn/hXYkMkQOvay+ZTIecavfjDwqSTUvYq+z7ETC3Wdl3tbbBQk+gpYZ uqLDXnLayG6vAmWiVWk3zCi1feyrx3ew8C/0JdgfyNrO7539novVlxhJAnKQCZyf0I+h Fq49bGhzm0ub2pSu5GvWMQLAl9q+p8oPCCkfdMXZSICAUElnOMZARGKd+KHSSiVnSyfr XChw== X-Forwarded-Encrypted: i=1; AJvYcCUdMm/m3kPV5UMA4dqAVoJ5AyN+Rzq0TbA7ruR5uCxb3m7w+AnVHHHpgjk7O9z4TtRrI7w/1XbnWRlQ@vger.kernel.org X-Gm-Message-State: AOJu0YxhwHZlAO43uTCaISLxbghQZx6+Wcmpf1w8MTE1gMVNY9l/URh6 7DKfL222IcS1SawRqNTjySuCeyYThLChzmiBFrfKoYTgTN8j0/+EIEYuiuUEmTCdfSZNepN6jYq 5P3h8cRgsepIz+woMD9mCL5mR1oKKmbigiPMt8w== X-Google-Smtp-Source: AGHT+IE+HCTz9/Hpne7uiESMruAIZ8sOYY9ablamvHhKXDnIFQMaJZtzXwjRu+Y8yXtv+wftvk256sWwlMRwxMdIsno= X-Received: by 2002:a05:690c:3708:b0:62f:aaaa:187a with SMTP id 00721157ae682-6dbcc26265bmr21823667b3.14.1726227857290; Fri, 13 Sep 2024 04:44:17 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240913103755.7290-1-quic_mukhopad@quicinc.com> <20240913103755.7290-6-quic_mukhopad@quicinc.com> In-Reply-To: <20240913103755.7290-6-quic_mukhopad@quicinc.com> From: Dmitry Baryshkov Date: Fri, 13 Sep 2024 14:44:06 +0300 Message-ID: Subject: Re: [PATCH v2 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P To: Soutrik Mukhopadhyay Cc: vkoul@kernel.org, kishon@kernel.org, konradybcio@kernel.org, andersson@kernel.org, simona@ffwll.ch, abel.vesa@linaro.org, robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, quic_khsieh@quicinc.com, konrad.dybcio@linaro.org, quic_parellan@quicinc.com, quic_bjorande@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, quic_riteshk@quicinc.com, quic_vproddut@quicinc.com Content-Type: text/plain; charset="UTF-8" On Fri, 13 Sept 2024 at 13:38, Soutrik Mukhopadhyay wrote: > > The Qualcomm SA8775P platform comes with a DisplayPort controller > with a different base offset than the previous SoCs, > add support for this in the DisplayPort driver. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: No change > > --- > drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index e1228fb093ee..e4954fd99eb0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -118,6 +118,12 @@ struct msm_dp_desc { > bool wide_bus_supported; > }; > > +static const struct msm_dp_desc sa8775p_dp_descs[] = { > + { .io_start = 0xaf54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, > + { .io_start = 0xaf5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true }, Please wait for the discussion to end before posting new iterations. In this case Bjorn pointed out that this is not the full configuration. Please add a comment, describing that there is a second MDSS, which isn't declared here as it wasn't validated. > + {} > +}; > + > static const struct msm_dp_desc sc7180_dp_descs[] = { > { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, > {} > @@ -162,6 +168,7 @@ static const struct msm_dp_desc x1e80100_dp_descs[] = { > }; > > static const struct of_device_id dp_dt_match[] = { > + { .compatible = "qcom,sa8775p-dp", .data = &sa8775p_dp_descs }, > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_descs }, > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_descs }, > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs }, > -- > 2.17.1 > -- With best wishes Dmitry