From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FA1C4332F for ; Mon, 12 Dec 2022 22:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233818AbiLLWf3 (ORCPT ); Mon, 12 Dec 2022 17:35:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233776AbiLLWf1 (ORCPT ); Mon, 12 Dec 2022 17:35:27 -0500 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30C63886 for ; Mon, 12 Dec 2022 14:35:26 -0800 (PST) Received: by mail-yb1-xb30.google.com with SMTP id v71so15520834ybv.6 for ; Mon, 12 Dec 2022 14:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IpAeK55ZtLsOItOVOsZUW0VX0dmUGZuhAd/spodi2Go=; b=t14B1twGGRg6SASEJ+ZLGhHuryfaHLhvHJZJifSYAGZy7SktUGgGzYTV4SMEtrr2F+ NtAzSMIt9OgezFwIGrt5tvSLxJ664bJKgh7QHEpd9DSKH+TibYunqdwkeoNB70HdtaC+ u3wF5OQ3i1B71t8u/ghJ1uxJc4G7oo6GVUpDcKo2KBURmuyEDvvMkQgZyhzxbVvXxlX0 r1n0D258M0NkEx9Si+rocmFToLwfkEAIVegzKll09XNS7xODgko0a+pvEqvWtJf0CYYM y2LR/qumoXQUQ4BY9gQ1KC1OlXq5qTTWEufUmBCTjL+Ijj8z3uWKmDPLG14ABDPisIxZ rCvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IpAeK55ZtLsOItOVOsZUW0VX0dmUGZuhAd/spodi2Go=; b=wuRb6RpjrkgxpAWm9/hEsqHK5RXtEQ17vPOedJLMCczZQcSktnLFKTGwOC2/h2Wkfy ypMHIQ0zUshsIxRHokR87VxKtKVpx77A9ty2QJFhwtQZHXoCs1Rno2xq4VgjcbXuMIQk NKIb+LZu7x1NQQQ9AQx1NIMwVOoalyyWMYouYU43uzk1ejw6o2iW5FeLCU2rVeRbIP/Y AfeJdlqmWgLeBzdiR8ps/yABxM4A8d77SeIMYoqfCgC4hmjKfeeerBA5aniZyFX07U7h KpheRvNzs/GfAFoux0nO3Rc6p25D73m+tfUVWwNuHwtyjNIn2u1dO8Brlg0caAHzCvA+ yH5Q== X-Gm-Message-State: ANoB5pnRoPEoaY8ShjS4qSt9GV+FEoir05Q9zXdIvR61Lze9b4/5ukDY E+UyUAAX5jVtzUfk4ogZd+N2y5i1kwMf5sm0rj1dUw== X-Google-Smtp-Source: AA0mqf6vQuxCOzGUSvZb2kDX2AlckUYquLDzfG7G1uiKoRmVPaZPcfA52u7eXv04oPAKviSZIokhuxUkroshPyUJ3hc= X-Received: by 2002:a25:384a:0:b0:710:a8a6:d45 with SMTP id f71-20020a25384a000000b00710a8a60d45mr3558285yba.152.1670884525944; Mon, 12 Dec 2022 14:35:25 -0800 (PST) MIME-Version: 1.0 References: <1670539015-11808-1-git-send-email-quic_khsieh@quicinc.com> <1670539015-11808-3-git-send-email-quic_khsieh@quicinc.com> <5a3865ed-8847-db04-3d60-f35438250bef@linaro.org> <5aa16223-dbf6-996c-1985-794302dcce91@quicinc.com> <8b306c8f-3089-4aaf-7fc1-038a8330c89a@quicinc.com> In-Reply-To: <8b306c8f-3089-4aaf-7fc1-038a8330c89a@quicinc.com> From: Dmitry Baryshkov Date: Tue, 13 Dec 2022 00:35:14 +0200 Message-ID: Subject: Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property To: Kuogee Hsieh Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, airlied@gmail.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 12 Dec 2022 at 19:51, Kuogee Hsieh wrote: > > > On 12/8/2022 4:35 PM, Dmitry Baryshkov wrote: > > On 09/12/2022 02:22, Kuogee Hsieh wrote: > >> > >> On 12/8/2022 4:11 PM, Dmitry Baryshkov wrote: > >>> On 09/12/2022 01:38, Kuogee Hsieh wrote: > >>>> > >>>> On 12/8/2022 3:33 PM, Dmitry Baryshkov wrote: > >>>>> On 09/12/2022 00:36, Kuogee Hsieh wrote: > >>>>>> Add both data-lanes and link-frequencies property into endpoint > >>>>>> > >>>>>> Changes in v7: > >>>>>> -- split yaml out of dtsi patch > >>>>>> -- link-frequencies from link rate to symbol rate > >>>>>> -- deprecation of old data-lanes property > >>>>>> > >>>>>> Changes in v8: > >>>>>> -- correct Bjorn mail address to kernel.org > >>>>>> > >>>>>> Changes in v10: > >>>>>> -- add menu item to data-lanes and link-frequecnis > >>>>>> > >>>>>> Changes in v11: > >>>>>> -- add endpoint property at port@1 > >>>>>> > >>>>>> Signed-off-by: Kuogee Hsieh ` > >>>>> > >>>>> Applying: dt-bindings: msm/dp: add data-lanes and link-frequencies > >>>>> property > >>>>> .git/rebase-apply/patch:47: trailing whitespace. > >>>>> > >>>>> .git/rebase-apply/patch:51: trailing whitespace. > >>>>> > >>>>> > >>>>> Also the dt_binding_check fails with an error for this schema. And > >>>>> after fixing the error in the schema I faced an example validation > >>>>> error. Did you check that the schema is correct and that the > >>>>> example validates against the schema? > >>>> > >>>> yes, but i run "make dt_binding_check > >>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml" > >>>> at mu v5.15 branch since > >>> > >>> I wouldn't ask you to post the log here. But I don't think that > >>> either of the errors that I see here is related to 5.15 vs 6.1-rc. > >>> > >>> In fact after applying this patch against 5.15 I saw the expected > >>> failure: > >>> > >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml: > >>> properties:required: ['port@0', 'port@1'] is not of type 'object', > >>> 'boolean' > >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml: > >>> properties: 'required' should not be valid under {'$ref': > >>> '#/definitions/json-schema-prop-names'} > >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml: > >>> ignoring, error in schema: properties: required > >>> > >>>> > >>>> "make dt_binding_check" does not work at msm-next branch. > >>> > >>> I went ahead and just checked. > >>> > >>> `make dt_binding_check DT_SCHEMA_FILES=display/msm` works cleanly > >>> in msm-next and reports a single example-related warning in > >>> msm-next-lumag. I pushed a patch to fix that warning (wich can > >>> hopefully be picked up by Abhinav into msm-fixes). So you can assume > >>> that both these branches have consistent error-free display/msm > >>> schemas. > >>> > >> I have clean msm-next branch (without my data-lines yaml patch > >> applied) and run "make dt_binding_check > >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/dp-controller.yaml", > >> then I saw below error messages. > >> > >> Have you run into this problem? > > > > No. > > Did you do anything to fix "older dtschema instance"? I did not since I hadn't had such a problem. I can refer again to the steps I provided you beforehand. The email was sent 6 days ago. No answer from your side since that time. > I had run "pip3 install dtschema --upgrade" and still not work. Can you please post a full log of this command? > > D you know how to fix this problem? > > Thanks, > > kuogee > > sort: -:2: disorder: 2022.1 > ERROR: dtschema minimum version is v2022.3 > make[2]: *** [check_dtschema_version] Error 1 > make[1]: *** [dt_binding_check] Error 2 > make: *** [__sub-make] Error 2 Please add the output of: which dt-validate dt-validate -V And also a full log of your failing kernel build. > I had run "pip3 install dtschema --upgrade" according Rob Herring response. > but it still shows same problem. > Please let know how can I fix this problem. > > > > >> > >> HOSTCC scripts/basic/fixdep > >> HOSTCC scripts/dtc/dtc.o > >> HOSTCC scripts/dtc/flattree.o > >> HOSTCC scripts/dtc/fstree.o > >> HOSTCC scripts/dtc/data.o > >> HOSTCC scripts/dtc/livetree.o > >> HOSTCC scripts/dtc/treesource.o > >> HOSTCC scripts/dtc/srcpos.o > >> HOSTCC scripts/dtc/checks.o > >> HOSTCC scripts/dtc/util.o > >> LEX scripts/dtc/dtc-lexer.lex.c > >> HOSTCC scripts/dtc/dtc-lexer.lex.o > >> HOSTCC scripts/dtc/dtc-parser.tab.o > >> HOSTLD scripts/dtc/dtc > >> sort: -:2: disorder: 2022.1 > >> ERROR: dtschema minimum version is v2022.3 > >> make[2]: *** [check_dtschema_version] Error 1 > >> make[1]: *** [dt_binding_check] Error 2 > >> make: *** [__sub-make] Error 2 > > > > This means that somewhere in your path you have an older dtschema > > instance. > > > > When you sent me a question regarding this error, I asked for the > > additional info. You provided none. Instead you went on sending the > > untested patch that doesn't work. > > since i can not test it on msm-next so that I did test it at my v5-15 > branch. Wrong. > > besides, i think i have to sent the whole series patches include this > one to address your new comments on other patch. > > is this correct? No. Please fix your system first, validate your patches and send them afterwards. You can not expect others to do your job. -- With best wishes Dmitry