devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI
@ 2023-09-24 18:33 Krzysztof Kozlowski
  2023-09-24 18:33 ` [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-24 18:33 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

DSI node does not accept nor use "label" property:

  qcom-apq8064-asus-nexus7-flo.dtb: dsi@4700000: Unevaluated properties are not allowed ('label' was unexpected)

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
index 9e033dc6e391..7fd3f164e7d4 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
@@ -1270,7 +1270,6 @@ mmss_sfpb: syscon@5700000 {
 		dsi0: dsi@4700000 {
 			compatible = "qcom,apq8064-dsi-ctrl",
 				     "qcom,mdss-dsi-ctrl";
-			label = "MDSS DSI CTRL->0";
 			#address-cells = <1>;
 			#size-cells = <0>;
 			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order
  2023-09-24 18:33 [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
@ 2023-09-24 18:33 ` Krzysztof Kozlowski
  2023-09-24 22:52   ` Dmitry Baryshkov
  2023-09-24 22:51 ` [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Dmitry Baryshkov
  2023-09-28  0:34 ` (subset) " Bjorn Andersson
  2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-24 18:33 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Bindings expect clocks to be in different order:

  qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:0: 'iface' was expected
  qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:1: 'core' was expected

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
index 311fd01a4f9e..6d1bf0eeb139 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
@@ -461,9 +461,9 @@ sdhc_1: mmc@8804000 {
 			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "hc_irq", "pwr_irq";
-			clocks = <&gcc GCC_SDCC1_APPS_CLK>,
-				 <&gcc GCC_SDCC1_AHB_CLK>;
-			clock-names = "core", "iface";
+			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
+				 <&gcc GCC_SDCC1_APPS_CLK>;
+			clock-names = "iface", "core";
 			status = "disabled";
 		};
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI
  2023-09-24 18:33 [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
  2023-09-24 18:33 ` [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
@ 2023-09-24 22:51 ` Dmitry Baryshkov
  2023-09-28  0:34 ` (subset) " Bjorn Andersson
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-09-24 22:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Sun, 24 Sept 2023 at 21:33, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> DSI node does not accept nor use "label" property:
>
>   qcom-apq8064-asus-nexus7-flo.dtb: dsi@4700000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order
  2023-09-24 18:33 ` [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
@ 2023-09-24 22:52   ` Dmitry Baryshkov
  0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-09-24 22:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On Sun, 24 Sept 2023 at 21:33, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bindings expect clocks to be in different order:
>
>   qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:0: 'iface' was expected
>   qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:1: 'core' was expected
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: (subset) [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI
  2023-09-24 18:33 [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
  2023-09-24 18:33 ` [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
  2023-09-24 22:51 ` [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Dmitry Baryshkov
@ 2023-09-28  0:34 ` Bjorn Andersson
  2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-09-28  0:34 UTC (permalink / raw)
  To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Krzysztof Kozlowski


On Sun, 24 Sep 2023 20:33:34 +0200, Krzysztof Kozlowski wrote:
> DSI node does not accept nor use "label" property:
> 
>   qcom-apq8064-asus-nexus7-flo.dtb: dsi@4700000: Unevaluated properties are not allowed ('label' was unexpected)
> 
> 

Applied, thanks!

[1/2] ARM: dts: qcom: apq8064: drop label property from DSI
      commit: 83daed13a5aa0ca563bfde920178ca67fbbdb5f3
[2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order
      commit: 88fc274cb6c4bd643b0157db2602f685af57b846

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-28  0:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-24 18:33 [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
2023-09-24 18:33 ` [RESEND PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
2023-09-24 22:52   ` Dmitry Baryshkov
2023-09-24 22:51 ` [RESEND PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Dmitry Baryshkov
2023-09-28  0:34 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).