Re: [RFC] arm64: dts: qcom: qrb5165-rb5: model the PMU of the QCA6391

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On Mon, 22 Jan 2024 at 20:22, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> I'm limiting the audience of this compared to the PCI power sequencing
> series as I wanted to run the DT part by the maintainers before I commit
> to a doomed effort.
>
> Here is the DT representation of the QCA6390's PMU with its inputs and
> outputs. If I were to implement the pwrseq framework that would be able
> to assign the relevant pwrseq data to the consumer based on the actual
> regulators and not abstract bt-pwrseq or wlan-pwrseq properties - would
> that fly with you?
>
> We'd need to deprecate the existing BT bindings but unfortunately they
> are already described as consuming the host PMIC regulators in bindings.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

My main concern is whether this is going to pass the regulator
subsystem locking. Basically you have a driver for regulators, which
will itself call into the regulator subsytem. It might be reentrant.
Or it might not.

> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 129 +++++++++++++++++++++--
>  arch/arm64/boot/dts/qcom/sm8250.dtsi     |  10 ++
>  2 files changed, 128 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index cd0db4f31d4a..c9b1600c57ef 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -108,6 +108,88 @@ lt9611_3v3: lt9611-3v3 {
>                 regulator-always-on;
>         };
>
> +       qca6390_pmu: pmu@0 {
> +               compatible = "qcom,qca6390-pmu";
> +
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
> +
> +               vddaon-supply = <&vreg_s6a_0p95>;
> +               vddpmu-supply = <&vreg_s2f_0p95>;
> +               vddrfa1-supply = <&vreg_s2f_0p95>;
> +               vddrfa2-supply = <&vreg_s8c_1p3>;
> +               vddrfa3-supply = <&vreg_s5a_1p9>;
> +               vddpcie1-supply = <&vreg_s8c_1p3>;
> +               vddpcie2-supply = <&vreg_s5a_1p9>;
> +               vddio-supply = <&vreg_s4a_1p8>;
> +
> +               bt-enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> +               wifi-enable-gpios = <&tlmm 20 GPIO_ACTIVE_HIGH>;
> +               swctrl-gpios = <&tlmm 124 GPIO_ACTIVE_HIGH>;
> +
> +               regulators {
> +                       vreg_pmu_rfa_cmn: ldo0 {
> +                               regulator-name = "vreg_pmu_rfa_cmn";
> +                               regulator-min-microvolt = <760000>;
> +                               regulator-max-microvolt = <840000>;
> +                       };
> +
> +                       vreg_pmu_aon_0p59: ldo1 {
> +                               regulator-name = "vreg_pmu_aon_0p59";
> +                               regulator-min-microvolt = <540000>;
> +                               regulator-max-microvolt = <840000>;
> +                       };
> +
> +                       vreg_pmu_wlcx_0p8: ldo2 {
> +                               regulator_name = "vreg_pmu_wlcx_0p8";
> +                               regulator-min-microvolt = <760000>;
> +                               regulator-max-microvolt = <840000>;
> +                       };
> +
> +                       vreg_pmu_wlmx_0p85: ldo3 {
> +                               regulator-name = "vreg_pmu_wlmx_0p85";
> +                               regulator-min-microvolt = <810000>;
> +                               regulator-max-microvolt = <890000>;
> +                       };
> +
> +                       vreg_pmu_btcmx_0p85: ldo4 {
> +                               regulator-name = "vreg_pmu_btcmx_0p85";
> +                               regulator-min-microvolt = <810000>;
> +                               regulator-max-microvolt = <890000>;
> +                       };
> +
> +                       vreg_pmu_rfa_0p8: ldo5 {
> +                               regulator-name = "vreg_pmu_rfa_0p8";
> +                               regulator-min-microvolt = <760000>;
> +                               regulator-max-microvolt = <840000>;
> +                       };
> +
> +                       vreg_pmu_rfa_1p2: ldo6 {
> +                               regulator-name = "vreg_pmu_rfa_1p2";
> +                               regulator-min-microvolt = <1187000>;
> +                               regulator-max-microvolt = <1313000>;
> +                       };
> +
> +                       vreg_pmu_rfa_1p7: ldo7 {
> +                               regulator_name = "vreg_pmu_rfa_1p7";
> +                               regulator-min-microvolt = <1710000>;
> +                               regulator-max-microvolt = <1890000>;
> +                       };
> +
> +                       vreg_pmu_pcie_0p9: ldo8 {
> +                               regulator_name = "vreg_pmu_pcie_0p9";
> +                               regulator-min-microvolt = <870000>;
> +                               regulator-max-microvolt = <970000>;
> +                       };
> +
> +                       vreg_pmu_pcie_1p8: ldo9 {
> +                               regulator_name = "vreg_pmu_pcie_1p8";
> +                               regulator-min-microvolt = <1710000>;
> +                               regulator-max-microvolt = <1890000>;
> +                       };
> +               };
> +       };
> +
>         thermal-zones {
>                 conn-thermal {
>                         polling-delay-passive = <0>;
> @@ -734,6 +816,24 @@ &pcie0_phy {
>         vdda-pll-supply = <&vreg_l9a_1p2>;
>  };
>
> +&pcieport0 {
> +       wifi@0 {
> +               compatible = "pci17cb,1101";
> +               reg = <0x10000 0x0 0x0 0x0 0x0>;
> +
> +               vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> +               vddaon-supply = <&vreg_pmu_aon_0p59>;
> +               vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> +               vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> +               vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
> +               vddrfa0-supply = <&vreg_pmu_rfa_0p8>;
> +               vddrfa1-supply = <&vreg_pmu_rfa_1p2>;
> +               vddrfa2-supply = <&vreg_pmu_rfa_1p7>;
> +               vddpcie0-supply = <&vreg_pmu_pcie_0p9>;
> +               vddpcie1-supply = <&vreg_pmu_pcie_1p8>;

This really feels like an overkill, All those voltages are handled by
the PMU itself, rather than being requested by the WiFi or BT drivers.

> +       };
> +};
> +
>  &pcie1 {
>         status = "okay";
>  };

-- 
With best wishes
Dmitry