From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B50DC77B73 for ; Thu, 1 Jun 2023 00:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbjFAA3F (ORCPT ); Wed, 31 May 2023 20:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjFAA3E (ORCPT ); Wed, 31 May 2023 20:29:04 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB127124 for ; Wed, 31 May 2023 17:29:02 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-ba827a34ba8so237351276.0 for ; Wed, 31 May 2023 17:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685579342; x=1688171342; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NEEjlzeLxFQftTZQSpKJW7Jq+wnau68354KXBq6LZXM=; b=DASrcWJUigO5nWpOPk4tjfh5Q25y9tW2ZNCwtl31oosKOjljcct+SiTn3TZeN3yQc4 EJ2Mhq07DbjHMZEWvgSauYe9bI6j68f9z6jvw2dcYl6YlsatEX8ggHKKBCAVd18yaTlT cLZGlLL/cK3XJBvKKrvFNd3DFJ8Jk8l7QWSfgiyYDI1qut/k81copaH0XHDiTLzrhdKl nymb+vvf0h3AIC1PvmRMVqAE9voOMuVqyhXlwZmleEQ+s4/zdkBF5gXUhIiAEP/cb4oQ e/XD4AigUJSTvNw/N2l3H68F92eQDNZ1sSsEDzIlzbMcz0NgTGdyS2m27pqioJmTNjc/ g+qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685579342; x=1688171342; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NEEjlzeLxFQftTZQSpKJW7Jq+wnau68354KXBq6LZXM=; b=EO7b97v+P7bW7ZmSqqbEDMUVOHjiPEcX72lHqasui3U2heuD2BHu0zI00NKEnHTO80 tVdTCUBgoZjzVp+jmmYSkXJVplxGBtI441IWjEmS+HdALNzW/xvbUbFzTopDcywsdx7h ZkZRNz07BLr0V5s90mQFn0SdXSteJAsHaEGJcGDn4M8lc0HVjKO/EwEM9zAjOU+Jcjnb gqptnposeQe8kgreNw8uy/wj3CrmZEURfApsfH5+16G/gzrIyGY3GbG+oSkHbGaP0koT xOXpuHMGxQ+BUMdWyXaMxg4K5ktU3PsEJfmPllrEwIWHUMqnzFesFVHa4GBaGdpwk2FQ HxNQ== X-Gm-Message-State: AC+VfDzJbPebR2y+j1UvYrS4VBybW7L+xhbmCIqkqoEmOvHIth3ultvv M+GhGN6vVn/y+nNc8AN8ZD1HW/XBRUHY+VwCP70ZlA== X-Google-Smtp-Source: ACHHUZ5iUMfJV/FOMlr08ahtzPGqh8EXAdjkfAkBYn2H1tsCyIX1DSM2KkkhEy6vsvNjLD1u9b8Hs3L79AxVpBIaYpk= X-Received: by 2002:a25:b08f:0:b0:b9a:6a68:b8da with SMTP id f15-20020a25b08f000000b00b9a6a68b8damr8271454ybj.25.1685579342118; Wed, 31 May 2023 17:29:02 -0700 (PDT) MIME-Version: 1.0 References: <20230531014248.3824043-1-dmitry.baryshkov@linaro.org> <20230531014248.3824043-2-dmitry.baryshkov@linaro.org> <3a0deecb-8235-8cf5-262e-8cb8d2349a4c@linaro.org> In-Reply-To: <3a0deecb-8235-8cf5-262e-8cb8d2349a4c@linaro.org> From: Dmitry Baryshkov Date: Thu, 1 Jun 2023 03:28:51 +0300 Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: power: reset: qcom-pon: define pm8941-pon To: Krzysztof Kozlowski Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 31 May 2023 at 21:59, Krzysztof Kozlowski wrote: > > On 31/05/2023 03:42, Dmitry Baryshkov wrote: > > On PM8941 pon doesn't store the reset reason. However we still need the > > wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon > > device. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../devicetree/bindings/power/reset/qcom,pon.yaml | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > index d96170eecbd2..eb3c88e501ef 100644 > > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > > @@ -19,6 +19,7 @@ properties: > > compatible: > > enum: > > - qcom,pm8916-pon > > + - qcom,pm8941-pon > > - qcom,pms405-pon > > - qcom,pm8998-pon > > - qcom,pmk8350-pon > > @@ -56,13 +57,22 @@ required: > > unevaluatedProperties: false > > > > allOf: > > - - $ref: reboot-mode.yaml# > > + - if: > > + not: > > + properties: > > + compatible: > > + contains: > > + const: qcom,pm8941-pon > > + then: > > + $ref: reboot-mode.yaml# > > Are you sure that this works, so pm8941 does not allow mode-* > properties? I am afraid they would still be considered evaluated, thus > your if-not is not effective. Yes, I checked that they trigger the schema validation error. If you'd prefer I can extend this 'if' with explicit 'mode-*: false'. -- With best wishes Dmitry