From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DB7C433EF for ; Wed, 6 Jul 2022 11:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbiGFLz4 (ORCPT ); Wed, 6 Jul 2022 07:55:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232846AbiGFLzz (ORCPT ); Wed, 6 Jul 2022 07:55:55 -0400 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B49E2872B for ; Wed, 6 Jul 2022 04:55:54 -0700 (PDT) Received: by mail-qt1-x82b.google.com with SMTP id bs20so17806838qtb.11 for ; Wed, 06 Jul 2022 04:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2xPPvWkX/4qbcpxkLhSz37/dg2kQ2TdyfBGP0fDH2yg=; b=cUsjsTcPftdO60OMEiKQ4hv8X2Er3f5roF3uW5EmdRGuZxAt/jWMXPjAFX7itH5ZFK vUSSJa1ffxzdS1t6yW4ILO0SO/fDZPzYPyH4Nt7i1uHMmC3hY0YSLaeS3011WTAs4uWR bds1oCBPN1inb2QCOT8bOgd94l08GVVEAmsNXaO+wyOWil6Iwlc8uKbI4k0uaAI3hEc9 N4VQ2NN1Xs6DUhn8t2R3MD3pnuVo6r5iApPFC98RxCk9bZE+XG2wOXUXHWgQ584D+med rNquHLcX0owEgVrBbSfHJ4SCfHaUWCGTwwwcYTnergywH4lO9IpTV+DUUQRw20149ZSK BI+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2xPPvWkX/4qbcpxkLhSz37/dg2kQ2TdyfBGP0fDH2yg=; b=5Pb2pje3AaG3fvTy+mxZMFEpFyVGgsYVYmpTc0aJHQSQKcwBVOfoX/IQE1PqbVqtSe cyNJ6J3DhM3A5g+Lt8zHDMB2tpBE1nvKoY36/fT+Rr03cxzmbswZjifCJ+iXgxbVaDlb 6ZOst2Q1rfrzZCE6f7oHKEIlWbjRP2wFsiCKyBrWytjvCYZz7eL0mMSaipveYwT4kezK +IoCCLUKSOyBR29pFx/YZ+mPNRkejGqKb50oqUxZy3PaCGOMMprFwHsEM2zm3+06MfCH pdumgxuQjIajUHxvznHtvvpWiGAcjxBuVMxDohcvOarnVAs2HI+f8PoedRyNx9DMZqdS OYZA== X-Gm-Message-State: AJIora/gluZj104QiLOtqlmL49VtCB79nhS7zHenKaS1+VBpnsAbLR7O CuuZkx/mzdPv2h25tcFOewmUmr92UrneAjvVt98sqA== X-Google-Smtp-Source: AGRyM1txd771wD0DyBtRq3n3JR0SKeoIUILx/nX4kQwQ9L56f1AyAZjwRJ1FoLu0egJmYMS134eL+7pj4xks9LiP5WA= X-Received: by 2002:a0c:f501:0:b0:472:f72c:7947 with SMTP id j1-20020a0cf501000000b00472f72c7947mr11667047qvm.119.1657108553408; Wed, 06 Jul 2022 04:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20220705133917.8405-1-ansuelsmth@gmail.com> <20220705133917.8405-4-ansuelsmth@gmail.com> <62c56348.1c69fb81.d2cad.2584@mx.google.com> In-Reply-To: <62c56348.1c69fb81.d2cad.2584@mx.google.com> From: Dmitry Baryshkov Date: Wed, 6 Jul 2022 14:55:41 +0300 Message-ID: Subject: Re: [PATCH 03/13] ARM: dts: qcom: add missing rpm regulators and cells for ipq8064 To: Christian Marangi Cc: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan McDowell Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 6 Jul 2022 at 13:26, Christian Marangi wrote: > On Wed, Jul 06, 2022 at 10:34:16AM +0200, Krzysztof Kozlowski wrote: > > On 05/07/2022 15:39, Christian Marangi wrote: > > > Add cells definition for rpm node and add missing regulators for the 4 > > > regulator present on ipq8064. There regulators are controlled by rpm and > > > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will > > > reject any regulator change request. > > > > > > Signed-off-by: Christian Marangi > > > Tested-by: Jonathan McDowell [...] > > > > + > > > rpmcc: clock-controller { > > > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > > > #clock-cells = <1>; > > > }; > > > + > > > + smb208_regulators: regulators { > > > + compatible = "qcom,rpm-smb208-regulators"; > > > + status = "okay"; > > > > Was the node disabled? > > > > smb208 is the normal and advised way to handle regulators on this > platform. Some device may want to not follow that and implement their > own regulator bypassing rpm so we add a status and on the current device > present upstream we set it disabled as it does use different regulators > implementation. Yep, this is correct. But you don't have to define status = 'okay'. It is the default. There are two typical patterns: 1) Disable by default foo.dtsi: abc: def { status = "disabled"; }; foo-bar.dtsi: &abc { status = "okay"; } 2) Enable by default foo.dtsi: abc: def { /* usual properties */ }; foo-bar.dtsi: &abc { status = "disabled"; } -- With best wishes Dmitry