From: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Chris Wright <chrisw@sous-sol.org>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Roland Stigge <stigge@antcom.de>
Subject: Re: [PATCH] SPI: at25: Parse dt settings
Date: Thu, 21 Jun 2012 08:10:53 -0300 [thread overview]
Message-ID: <CAAAP30G6zE5UmVMPPDGpwzHXG5zN3ZZfJ9u4W2TM1B5ccF50Lw@mail.gmail.com> (raw)
In-Reply-To: <CAMSQXEHOtgk7wRRqOdpMaTvpxFd1Cpom=BG65GheY6Z4p2Jc3A@mail.gmail.com>
On Thu, Jun 21, 2012 at 6:49 AM, Ivo Sieben <meltedpianoman@gmail.com> wrote:
> One small remark:
> In case of platform_data, the "if (!chip)" check has been removed and
> is now only handled in the device tree initialization.
> Maybe add this check to the platform initialization as well:
>
> } else {
> if (!spi->dev.platform_data) {
> dev_dbg(&spi->dev, "no chip description\n");
> err = -ENODEV;
> goto fail;
> }
> chip = *(struct spi_eeprom *)spi->dev.platform_data;
> }
Thanks for finding that out. I will fix that case.
This patch was already merged to gregh/char-misc:
http://git.kernel.org/?p=linux/kernel/git/gregkh/char-misc.git;a=shortlog;h=refs/heads/char-misc-next
I will implement a patch to fix this against the original one.
next prev parent reply other threads:[~2012-06-21 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 12:59 [PATCH] SPI: at25: Parse dt settings Alexandre Pereira da Silva
2012-06-21 9:49 ` Ivo Sieben
2012-06-21 11:10 ` Alexandre Pereira da Silva [this message]
2012-06-21 11:55 ` Alexandre Pereira da Silva
2012-06-21 14:31 ` Ivo Sieben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAAP30G6zE5UmVMPPDGpwzHXG5zN3ZZfJ9u4W2TM1B5ccF50Lw@mail.gmail.com \
--to=aletes.xgr@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).