From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE676C433F5 for ; Mon, 9 May 2022 14:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237063AbiEIOVT (ORCPT ); Mon, 9 May 2022 10:21:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236883AbiEIOVT (ORCPT ); Mon, 9 May 2022 10:21:19 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D9F4200F68 for ; Mon, 9 May 2022 07:17:16 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id kq17so27127265ejb.4 for ; Mon, 09 May 2022 07:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=Se5eMb8Ygo8+NTsu2WGGmLwSiZe3RssFpzMyc+7jXSDykSJnAVSZVnd/OngGPWZciL TqOhSSgSmDT040EiixkOlRjSjs+ukuyf54/dNj07uwd2adCU7iAHQeyZ6NPWcbIYVPwR pnseMj0cI03Ui9b5xM9w/yOlvf2/OlxlznUm1jexmSPMmaEiax93PQoJ/G6Q+n7fow9z IeuitDasdXBRSpB+6VIA+P3OanKlTTP+m6n8bakAwn+q9cJfZqwF1lR8LLdZPHpM+15i QZvAmWZBOy2/SBull0eHOksCzYbIomn1nr2T6ttdbSEDr1YAhsbO0VVKPlHOwot8XrnA S8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=PhkzfrATEFzl8Go++c4hv7b0f3kEkBQg5E5Ycg/HjNYAKMIIKNp5SQiVzKcY6J8Dg+ nu29zfdw3+H4cIkymua+VN8d57Hp5sJw4SVPmkM3pSvqq/UIJ9/n3x0Di20ROiCJVpgw n2odKhl/SRXjbZM57gEBfTcxVZ08IQunvKglwTklZYEoj465TeMniCmoJMIxoHLYzBfF 3pD5w4UIC6Msiv5fjEwDrt0b1eoHoWsGo+f44olu8z+NGNZGlaHUg354wEQGc9UHe/y/ b/Wm2vMclUsTyBMVuTntn2Ld0rc4TbJmxFawixcb4OVobJI0cjpQFwHTd7CJiJvsvVBk 8GOg== X-Gm-Message-State: AOAM531fNkD1DGZ5D92YT0PUMVo604x3qADVoX9/tsEf+CLzmPrOHHQ0 mEDHQj7+Myh98lq2w66PE9GVf/fmjAom0HQkWdF4hA== X-Google-Smtp-Source: ABdhPJz4oPKheaglIPZCKrUFsKejt51Mh50V9/DGs7u8F7syBlw3wHnbVvg9K8d9bl9luUK/vJye5kZrXA5cwi3Keig= X-Received: by 2002:a17:907:a0c8:b0:6f7:492e:e74c with SMTP id hw8-20020a170907a0c800b006f7492ee74cmr11393092ejc.670.1652105834875; Mon, 09 May 2022 07:17:14 -0700 (PDT) MIME-Version: 1.0 References: <20220508202544.501981-1-frattaroli.nicolas@gmail.com> <20220508202544.501981-4-frattaroli.nicolas@gmail.com> In-Reply-To: <20220508202544.501981-4-frattaroli.nicolas@gmail.com> From: Ezequiel Garcia Date: Mon, 9 May 2022 11:17:03 -0300 Message-ID: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Hantro encoder node to rk356x To: Nicolas Frattaroli Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nicolas, On Sun, May 8, 2022 at 5:26 PM Nicolas Frattaroli wrote: > > The RK3566 and RK3568 come with a dedicated Hantro instance solely for > encoding. This patch adds a node for this to the device tree, along with > a node for its MMU. > > Signed-off-by: Nicolas Frattaroli > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 7cdef800cb3c..2e3c9e1887e3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -508,6 +508,27 @@ gpu: gpu@fde60000 { > status = "disabled"; > }; > > + vepu: video-codec@fdee0000 { > + compatible = "rockchip,rk3568-vepu"; > + reg = <0x0 0xfdee0000 0x0 0x800>; > + interrupts = ; > + interrupt-names = "vepu"; It this block "encoder only" and if so, maybe we should remove the "interrupt-names" [1]? The driver is able to handle it. See: https://elixir.bootlin.com/linux/latest/source/drivers/staging/media/hantro/hantro_drv.c#L962 You might have to adjust the dt-bindings for this. [1] https://lore.kernel.org/linux-media/20210324151715.GA3070006@robh.at.kernel.org/ Thanks, Ezequiel > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "hclk"; > + iommus = <&vepu_mmu>; > + power-domains = <&power RK3568_PD_RGA>; > + }; > + > + vepu_mmu: iommu@fdee0800 { > + compatible = "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdee0800 0x0 0x40>; > + interrupts = ; > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3568_PD_RGA>; > + #iommu-cells = <0>; > + }; > + > sdmmc2: mmc@fe000000 { > compatible = "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xfe000000 0x0 0x4000>; > -- > 2.36.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip