From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1517C61DD8 for ; Thu, 12 Nov 2020 05:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CDBC20825 for ; Thu, 12 Nov 2020 05:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HWhp+x5n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbgKLFdF (ORCPT ); Thu, 12 Nov 2020 00:33:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728864AbgKLEcu (ORCPT ); Wed, 11 Nov 2020 23:32:50 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3781BC0613D1 for ; Wed, 11 Nov 2020 20:32:48 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id w13so5768051eju.13 for ; Wed, 11 Nov 2020 20:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PrJGFWR5LfPadBQJXtxR3X13DiYJSukzmCqstyB653Y=; b=HWhp+x5nR3T+EuumQWwhx5XTPD7QV5SlMbprd7oGYb7NT1tsUS8M5b4CCExQirLXf1 n6xB1vMrsTHoCd3FbJvdOGzMuDQtsl1hs78cs62DjPqqlEQe7GQ0p/ZW5fyjKOmsxAtD iRHM55F9z6oGEmav+yyjAu5YCy5KSCZCidFCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PrJGFWR5LfPadBQJXtxR3X13DiYJSukzmCqstyB653Y=; b=H2E2e/Ne9jVIGX+nVPm4e5ub/7mgaelwJRwFq5ir3x89h8Ktdj9nIlTxPiGbEibIbI hR1LcgHTsKYSmYRICZcIv9j/TJiRtrI2E8XmqEvkcypKeNDs7kb1iS3jtcCygGu5F1GA sCuUhF6QUtXzdn81Ze0Wg/aCrPYerkqFrh6D60PPl9NtidYc627TGEFNrNlVPe6ffiJt c8gCgIAH7oY/YIQorW1l3aaiToku2Il8UBjd658tNju3T51FcQu505kcfaJfU77e7+eQ Wn8K3CXL0n+MXiHhxXqzTdQ5PVLosOj7nqPFie94sMglEqciHpjgdY61diuvTPjFPLQo JMvA== X-Gm-Message-State: AOAM532UhdaHE6AYjQUkXk5ACbp7nOabWzu6yXu2IfW3vdWuzJT9ORVs qWWhfsbW7gQUMN+RyfQpmHsgykRyzmf1Fg== X-Google-Smtp-Source: ABdhPJwLv/doovMNWwksutCnt0h6T7PijYrcjBM6LgzksqnW2+6EePpVY0MXWPrOhfxZgK9xGNaHBQ== X-Received: by 2002:a17:906:1a07:: with SMTP id i7mr27697616ejf.473.1605155566572; Wed, 11 Nov 2020 20:32:46 -0800 (PST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id k4sm1773760edq.73.2020.11.11.20.32.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 20:32:46 -0800 (PST) Received: by mail-ej1-f45.google.com with SMTP id dk16so5779389ejb.12 for ; Wed, 11 Nov 2020 20:32:46 -0800 (PST) X-Received: by 2002:adf:e54f:: with SMTP id z15mr32685970wrm.159.1605155209811; Wed, 11 Nov 2020 20:26:49 -0800 (PST) MIME-Version: 1.0 References: <20191204124732.10932-1-Jerry-Ch.chen@mediatek.com> <1588903371.16825.14.camel@mtksdccf07> <20200521183825.GB249683@chromium.org> <1593526253.29676.28.camel@mtksdccf07> <20200630171912.GE1212092@chromium.org> <1605095509.28992.7.camel@mtksdccf07> In-Reply-To: <1605095509.28992.7.camel@mtksdccf07> From: Tomasz Figa Date: Thu, 12 Nov 2020 13:26:39 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V4 0/4] media: platform: Add support for Face Detection (FD) on mt8183 SoC To: Jerry-ch Chen Cc: "hans.verkuil@cisco.com" , HansVerkuil , "laurent.pinchart+renesas@ideasonboard.com" , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "pihsun@chromium.org" , "yuzhao@chromium.org" , "zwisler@chromium.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , =?UTF-8?B?U2ogSHVhbmcgKOm7g+S/oeeSiyk=?= , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , =?UTF-8?B?RnJlZGVyaWMgQ2hlbiAo6Zmz5L+K5YWDKQ==?= , =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , "linux-media@vger.kernel.org" , srv_heupstream , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 11, 2020 at 8:51 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Wed, 2020-07-01 at 01:19 +0800, Tomasz Figa wrote: > > Hi Jerry, > > > > On Tue, Jun 30, 2020 at 10:10:53PM +0800, Jerry-ch Chen wrote: > > > Hi Tomasz, > > > > > > On Thu, 2020-05-21 at 18:38 +0000, Tomasz Figa wrote: > > > > Hi Jerry, > > > > > > > > On Wed, May 13, 2020 at 11:45:37PM +0200, Tomasz Figa wrote: > > > > > Hi Jerry, > > > > > > > > > > On Fri, May 8, 2020 at 4:03 AM Jerry-ch Chen wrote: > > > > > > > > > > > > Hi Laurent, Tomasz, Matthias, > > > > > > > > > > > > gentle ping for this patch set, > > > > > > If no new comments, I would like to send a newer version. > > > > > > > > > > > > > > > > Sorry, I still haven't had a chance to look at the series, so feel > > > > > free to send a new version and I will take a look at the new one. > > > > > > > > > > > > > Finally found some time to review the series. Again sorry for the delay > > > > and thanks for your patience. > > > > > > > > Some general comments: > > > > 1) The metadata format FourCC should be added in a separate patch, > > > > together with documentation for it. > > > > 2) Control IDs, structs used by the userspace, etc. should be defined in > > > > a header under include/uapi/linux. > > > > > > > > Please also check my replies to particular patches for further comments. > > > > > > > > Best regards, > > > > Tomasz > > > > > > Appreciate for your reply, > > > > > > So far, I've locally created an uapi header: > > > include/uapi/linux/mtk_fd_40.h > > > which provides some values, control ids, and the definitions of > > > structures that would be needed by user of mtk_fd_40 driver. > > > In addition, I also provide a MACRO as example in comments that can > > > extract the struct member with bit length and offset > > > definitions(eliminate the bit-fields). > > > > > > Also, I would like to rename struct fd_user_output with struct > > > mtk_fd_hw_result. I worry fd_user_output would be a confusing name. > > > > The change sounds good to me. > > > > > I will add them in a separate patch in next version. > > > > > > > Okay. > > > > > I am still working on the documentation, which might be > > > Documentation/media/uapi/v4l/pixfmt-meta-mtk-fd-40.rst. > > > Refering the other pixfmt-*.rst files, I will try to provide the > > > flat-table of the metadata with the structure of the mtk_fd_hw_result. > > > > > > > Sounds good to me. > > > > > I am confusing that should I remain the name with -40 in the tail of rst > > > file? > > > > The header and documentation file names should match the driver name. I > > just noticed there is some inconsistency in the naming, though. The > > driver seems to be located under drivers/media/platform/mtk-isp/fd, but > > the driver name in the platform driver struct and as reported by > > VIDIOC_QUERYCAP seems to be "mtk-fd-4.0". > > > Since we have many mtk-* drivers in the tree currently, I think it might > > make sense to consolidate them under drivers/media/platform/mediatek, > > similarly to drivers/media/platform/qcom or /rockchip. But it could be > > done later, as a follow-up. > > > > My suggestion would be to place the driver under > > drivers/media/platform/mtk-fd-40 and also rename the related Kconfig > > symbol to include the _40 suffix. > > > > What do you think? > > > > I Appreciate your comments, > Sorry for the late reply. > > Would it be possible for me to replace the driver as drivers/media/platform/mtk_fd/mtk-fd-40?(Just like mtk-isp/isp_50) > I'm not a big fan of duplicating "mtk fd" in the path. How about just making it drivers/media/platform/mtk-fd-40? Best regards, Tomasz