Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

[Chun-Kuang Hu <chunkuang.hu@kernel.org>]

Hi, Qingfang:

DENG Qingfang <dqfext@gmail.com> 於 2021年4月6日 週二 下午10:19寫道：
>
> Add support for MediaTek PHYs found in MT7530 and MT7531 switches.
> The initialization procedure is from the vendor driver, but due to lack
> of documentation, the function of some register values remains unknown.
>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
>  drivers/net/phy/Kconfig    |   5 ++
>  drivers/net/phy/Makefile   |   1 +
>  drivers/net/phy/mediatek.c | 109 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 115 insertions(+)
>  create mode 100644 drivers/net/phy/mediatek.c
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index a615b3660b05..edd858cec9ec 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -207,6 +207,11 @@ config MARVELL_88X2222_PHY
>           Support for the Marvell 88X2222 Dual-port Multi-speed Ethernet
>           Transceiver.
>
> +config MEDIATEK_PHY

There are many Mediatek phy drivers in [1], so use a specific name.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/mediatek?h=v5.12-rc6

Regards,
Chun-Kuang.

> +       tristate "MediaTek PHYs"
> +       help
> +         Supports the MediaTek switch integrated PHYs.
> +
>  config MICREL_PHY
>         tristate "Micrel PHYs"
>         help