From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomeu Vizoso Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node Date: Mon, 21 Mar 2016 09:23:04 +0100 Message-ID: References: <1458300056-6174-1-git-send-email-tomeu.vizoso@collabora.com> <56EC744F.90308@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <56EC744F.90308-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Russell King , Heiko Stuebner , Pawel Moll , Ian Campbell , Rob Herring , Kumar Gala , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Giuseppe Cavallaro List-Id: devicetree@vger.kernel.org On 18 March 2016 at 22:34, Andreas F=C3=A4rber wrote= : > Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso: >> So the dwmac device manages to probe again. >> >> Signed-off-by: Tomeu Vizoso >> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression") >> --- >> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot= /dts/rk3288-rock2-som.dtsi >> index 1ece66f3e162..4ba7ddecb478 100644 >> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi >> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi >> @@ -101,6 +101,14 @@ >> snps,reset-delays-us =3D <0 10000 30000>; >> rx_delay =3D <0x10>; >> tx_delay =3D <0x30>; >> + mdio0 { >> + #address-cells =3D <1>; >> + #size-cells =3D <0>; >> + compatible =3D "snps,dwmac-mdio"; >> + ethphy1: ethernet-phy@1 { >> + reg =3D <1>; >> + }; >> + }; > > This is a) ugly for lack of white lines in between, b) unnecessary si= nce > this is being fixed in the stmmac driver where it will benefit more t= han > just this one SoM. So is this redundant information, or just not necessary with the present kernel driver because of some assumption in its current implementation? Thanks, Tomeu > Regards, > Andreas > >> }; >> >> &i2c0 { > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (= AG N=C3=BCrnberg) -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html