From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomeu Vizoso Subject: Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay Date: Wed, 21 Jan 2015 15:55:18 +0100 Message-ID: References: <1421338359-27467-1-git-send-email-tomeu.vizoso@collabora.com> <1421338359-27467-9-git-send-email-tomeu.vizoso@collabora.com> <54B7F9FB.7030100@wwwdotorg.org> <54BFAF7E.1030703@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ulf Hansson Cc: Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Javier Martinez Canillas , Dylan Reid , Simon Glass , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chris Ball , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-mmc List-Id: devicetree@vger.kernel.org On 21 January 2015 at 15:15, Ulf Hansson wrote: > On 21 January 2015 at 14:54, Tomeu Vizoso wrote: >> On 01/21/2015 11:44 AM, Ulf Hansson wrote: >>> On 15 January 2015 at 18:33, Stephen Warren wrote: >>>> On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: >>>>> >>>>> Signed-off-by: Tomeu Vizoso >>>> >>>> >>>> Ah, having read the explanation in the next patch, I think ... >>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt >>>>> b/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt >>>> >>>> >>>>> +- delay : delay to wait after driving the reset gpio active [ms]. >>>> >>>> >>>> ... delay is the wrong name. reset-pulse-width or reset-pulse-length would >>>> be better. delay sounds like a delay after resetting the device before it >>>> can be accessed. >>> >>> I agree with Stephen's proposal. >> >> Cool. >> >>> This patch needs to be rebased and retested on latest version the >>> mmc-pwrseq patches. >> >> Sure. >> >>> Moreover, if you think the patchset which $subject >>> patch is a part of is material for 3.20, I will need to share an >>> immutable branch with the mmc-pwrseq patches for ARM SOC to pull in, >>> tell me if you need that. >> >> I don't think this will make 3.20 as I have other series with higher >> priority and there's quite some work left to do on this one. > > If that's the case, I might as well consider this patch separately and > take it through my mmc tree. Of course, that means you anyway need to > rebase/test it. Sounds good, I expect to send a v3 tomorrow. Regards, Tomeu > Kind regards > Uffe > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html