From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Rob Herring <robherring2@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andrew Victor <linux@maxim.org.za>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 06/11] memory: atmel-ebi: add DT bindings documentation
Date: Fri, 7 Nov 2014 17:19:33 +0100 [thread overview]
Message-ID: <CAAObsKDkqksPyidfQmcHtShd3u7AFOd1RwLh3FRWPus2KjnBQA@mail.gmail.com> (raw)
In-Reply-To: <20141107164940.663f5423@bbrezillon>
On 7 November 2014 16:49, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Fri, 7 Nov 2014 09:21:39 -0600
> Rob Herring <robherring2@gmail.com> wrote:
>
>> On Wed, Nov 5, 2014 at 10:01 AM, Boris Brezillon
>> <boris.brezillon@free-electrons.com> wrote:
>> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>
>> Perhaps some commit msg?
>
> Yes, I was just lazy and though this series would make another round
> anyway :-).
>
> I'll add a commit log to all my commits...
>
>>
>> While this binding seems mostly okay to me, this is the 2nd memory
>> controller binding I've looked at in the last day [1]. There are
>> probably some others already as well. This makes me think we need a
>> generic binding here. At least the node structure and how we define
>> chip selects should be common.
>
> Sure.
> Any suggestion ?
I unfortunately cannot see much benefit to a generic binding, but
maybe that's because the one in T124 is a bit special? I'm very
interested in hearing proposals though.
Thanks,
Tomeu
next prev parent reply other threads:[~2014-11-07 16:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 16:01 [PATCH v2 00/11] memory: add Atmel EBI (External Bus Interface) driver Boris Brezillon
[not found] ` <1415203287-21517-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-05 16:01 ` [PATCH v2 01/11] mfd: syscon: Add atmel-matrix registers definition Boris Brezillon
[not found] ` <1415203287-21517-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-07 13:45 ` Alexandre Belloni
[not found] ` <20141107134510.GC4068-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2014-11-07 14:14 ` Boris Brezillon
2014-11-10 9:47 ` Lee Jones
2014-11-05 16:01 ` [PATCH v2 03/11] mfd: syscon: Add atmel-smc " Boris Brezillon
[not found] ` <1415203287-21517-4-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-10 9:57 ` Lee Jones
2014-12-01 9:38 ` Boris Brezillon
2014-12-01 9:43 ` Nicolas Ferre
2014-11-05 16:01 ` [PATCH v2 08/11] ARM: at91/dt: add HSMC (Static Memory Controller) node in sama5d3 dtsi Boris Brezillon
2014-11-05 16:01 ` [PATCH v2 09/11] ARM: at91/dt: add matrix " Boris Brezillon
2014-11-05 16:01 ` [PATCH v2 10/11] ARM: at91/dt: add EBI (External Bus Interface) " Boris Brezillon
2014-11-05 16:01 ` [PATCH v2 11/11] ARM: at91/dt: add NOR definition in sama5d3xcm dtsi Boris Brezillon
2014-11-07 13:41 ` [PATCH v2 00/11] memory: add Atmel EBI (External Bus Interface) driver Alexandre Belloni
[not found] ` <20141107134112.GB4068-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2014-11-07 14:19 ` Boris Brezillon
2014-11-05 16:01 ` [PATCH v2 02/11] mfd: syscon: Add Atmel Matrix bus DT binding documentation Boris Brezillon
2014-11-10 9:55 ` Lee Jones
2014-11-05 16:01 ` [PATCH v2 04/11] mfd: syscon: Add Atmel SMC binding doc Boris Brezillon
2014-11-10 9:55 ` Lee Jones
2014-11-05 16:01 ` [PATCH v2 05/11] memory: add Atmel EBI (External Bus Interface) driver Boris Brezillon
2014-11-05 16:53 ` Jean-Jacques Hiblot
2014-11-05 16:59 ` Boris Brezillon
2014-11-05 17:05 ` Jean-Jacques Hiblot
2014-11-05 16:01 ` [PATCH v2 06/11] memory: atmel-ebi: add DT bindings documentation Boris Brezillon
2014-11-05 16:22 ` Jean-Jacques Hiblot
2014-11-05 16:39 ` Boris Brezillon
[not found] ` <1415203287-21517-7-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-07 13:55 ` Alexandre Belloni
2014-11-07 15:21 ` Rob Herring
2014-11-07 15:49 ` Boris Brezillon
2014-11-07 16:19 ` Tomeu Vizoso [this message]
2014-11-07 19:39 ` Rob Herring
2014-11-05 16:01 ` [PATCH v2 07/11] ARM: at91: select ATMEL_EBI when compiling a kernel for at91sam9 or sama5d3 Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAObsKDkqksPyidfQmcHtShd3u7AFOd1RwLh3FRWPus2KjnBQA@mail.gmail.com \
--to=tomeu.vizoso@collabora.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jjhiblot@traphandler.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).