From: Shawn Guo <shawn.guo@linaro.org>
To: Rob Herring <robh@kernel.org>,
Sriharsha Allenki <sallenki@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Anu Ramanathan <anur@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding
Date: Tue, 13 Nov 2018 12:59:38 +0800 [thread overview]
Message-ID: <CAAQ0ZWS-j06YM+Vs64RC_e1M9s_5bZfCWyL95SSaKVENJv7BNw@mail.gmail.com> (raw)
In-Reply-To: <20181113034200.GD20049@tiger>
Hi Sriharsha,
On Tue, Nov 13, 2018 at 11:42 AM Shawn Guo <shawn.guo@linaro.org> wrote:
<snip>
> > > +- qcom,init-seq:
> > > + Value type: <u32 array>
> > > + Definition: Should contain a sequence of <offset value delay> tuples to
> > > + program 'value' into phy register at 'offset' with 'delay'
> > > + in us afterwards.
> >
> > If we wanted this type of thing in DT, we'd have a generic binding (or
> > forth).
>
> Right now, this is a qualcomm usb phy specific bindings - first used in
> qcom,usb-hs-phy.txt and I extended it a bit for my phy. As this is not
> a so good hardware description, I'm a little hesitated to make it
> generic for other platforms to use in general. What about we put off it
> a little bit until we see more platforms need the same thing?
Are those register write sequences really required here? At least,
from the test I do, it still works with this property dropped.
Shawn
next prev parent reply other threads:[~2018-11-13 4:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 7:04 [PATCH 0/2] Add Synopsys High-Speed USB PHY driver for Qualcomm SoCs Shawn Guo
2018-11-08 7:04 ` [PATCH 1/2] dt-bindings: phy: Add Qualcomm Synopsys High-Speed USB PHY binding Shawn Guo
2018-11-09 5:08 ` Vinod Koul
2018-11-09 6:31 ` Shawn Guo
2018-11-09 11:06 ` Vinod Koul
2018-11-12 19:24 ` Rob Herring
2018-11-13 3:42 ` Shawn Guo
2018-11-13 4:59 ` Shawn Guo [this message]
2018-11-17 15:13 ` Rob Herring
2018-11-19 6:55 ` Shawn Guo
2018-11-19 7:10 ` Vivek Gautam
2018-11-19 9:15 ` Shawn Guo
2018-11-08 7:04 ` [PATCH 2/2] phy: qualcomm: Add Synopsys High-Speed USB PHY driver Shawn Guo
2018-11-09 5:22 ` Vinod Koul
2018-11-09 6:52 ` Shawn Guo
2018-11-09 11:08 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAQ0ZWS-j06YM+Vs64RC_e1M9s_5bZfCWyL95SSaKVENJv7BNw@mail.gmail.com \
--to=shawn.guo@linaro.org \
--cc=anur@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).