From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380D6C04A95 for ; Thu, 29 Sep 2022 07:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235174AbiI2HoB (ORCPT ); Thu, 29 Sep 2022 03:44:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235520AbiI2Hnp (ORCPT ); Thu, 29 Sep 2022 03:43:45 -0400 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BCF27D789; Thu, 29 Sep 2022 00:43:41 -0700 (PDT) Received: by mail-ua1-x935.google.com with SMTP id a4so209066uao.0; Thu, 29 Sep 2022 00:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=hUW+w97bjwcMZAz2wEha3h2rI21nTjZgAo+7PEzzR7o=; b=IE9LHSxpzmDUKXAXpwHaYnHjLj1WufJVEYfJ1hGOFxil3rrScoNoLneEmDUcqYGDo/ cmnDLwBy5pEenkueOTqCV+am/5vXym19TECHw5twZhfNwDVDerAskkddsMYTI5iyXcb9 DKeNtto5a2ndL2uhg4dGQ+GhgCdAK8SvkRUTbps0BQnaxHCtqGHEWrXW1L8fXhtkJtvK xEbpRhYNxNBRsDCHgiwHkY7GxRqwABdkPK0KVFe4aKZvOyCNtvpSM5qwc9EXYZdj7Ccx +pI87QqvzlYDGu6n8JKzdWzkbjB8p0Z8F352cBkYLNp5LL5IyZKCRiZJ4CAtoLvoTv3W 5eTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=hUW+w97bjwcMZAz2wEha3h2rI21nTjZgAo+7PEzzR7o=; b=iA3hcRubxNaD3F5znpW2v21sAUQ02aV/Eme5ySqZHWX2XGMZ0hqc6PqrS2aNYJzCNM 7XOvA9WeLsxI9jSHdYHeYAUmcSjsTRoM3vxHH7+QNUAIXQhUPRmtN/p1fuQWuVwaY+yY NqLdeyF/QAJmjpVkMMMVAuksYkSA7dTkMKpTXCQej3Rgmoq+bIg//oIsJuqJcTFSXN1r 97IbqBFpd5a90gMxtx/NJO6ArIouOZ17FKvICxpO6nIMeM+O298LNBshSr6kCFsg8oqn tABsvapuLbbAg6Ba5zRcZcDTRyBDniyGf+wIk5KefrcvGObvxQA5EEAs9p+/5BzIRvy0 p03g== X-Gm-Message-State: ACrzQf1hS+urFFtsOMtrmsHyu8dYArGsdKXmUErK191kYZC4dOmVgEZT yPsBZmS3mPj7refPDuVFDeUGfv+OConztQZYPD8= X-Google-Smtp-Source: AMsMyM7ZHbYAiRKbQseodi2xdbkJcMUR30vIeLDXSMJPODyQS/Sgc7Hny7j2kIzLs5PAY4GuSRRyTMEfCI5USrXqyrw= X-Received: by 2002:a9f:3767:0:b0:3d1:2de3:12a8 with SMTP id a36-20020a9f3767000000b003d12de312a8mr881708uae.47.1664437420589; Thu, 29 Sep 2022 00:43:40 -0700 (PDT) MIME-Version: 1.0 References: <20220928092937.27120-1-zhang.lyra@gmail.com> In-Reply-To: From: Chunyan Zhang Date: Thu, 29 Sep 2022 15:43:04 +0800 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: gpio: Conver Unisoc GPIO controller binding to yaml To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Baolin Wang , Orson Zhai , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 29 Sept 2022 at 15:02, Krzysztof Kozlowski wrote: > > On 29/09/2022 04:29, Chunyan Zhang wrote: > > Hi Krzysztof, > > > > On Wed, 28 Sept 2022 at 19:31, Krzysztof Kozlowski > > wrote: > >> > >> On 28/09/2022 11:29, Chunyan Zhang wrote: > >>> From: Chunyan Zhang > >>> > >>> Convert the Unisoc gpio controller binding to DT schema format. > >>> > >> > >> > >> Thank you for your patch. There is something to discuss/improve. > >> > >>> diff --git a/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml > >>> new file mode 100644 > >>> index 000000000000..c0cd1ed9809b > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/gpio/sprd,gpio.yaml > >>> @@ -0,0 +1,70 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +# Copyright 2022 Unisoc Inc. > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/gpio/sprd,gpio.yaml# > >> > >> Use compatible as filename, so sprd,sc9860-gpio.yaml > > > > Humm... This is not only for SC9860, also for other IPs, UMS512 as an > > example which added in this patchset. > > > > > Then it's ok. It seems you have also typo in commit subject (Conver). Ah yes -_-||, will fix that. > > Best regards, > Krzysztof >