Re: [PATCH v2 2/2] Add documentation for tca6507 devicetree bindings.

[Belisko Marek <marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1595 bytes --]

On Thu, Nov 8, 2012 at 12:14 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>wrote:

> On 11/07/2012 01:55 PM, Marek Belisko wrote:
>
> > diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt
> b/Documentation/devicetree/bindings/leds/tca6507.txt
>
> > +LEDs conected to tca6507
> > +
> > +Required properties:
> > +- compatible : should be : "leds-tca6507".
>
> "ti,tca6507" would be more typical.
>
OK will post update for that

>
> > +Each led is represented as a sub-node of the leds-tca6507 device.
> > +
> > +LED sub-node properties:
> > +- label : label for this LED
> > +- reg : number of LED line (could be from 0 to 6)
> > +- linux,default-trigger : led default trigger
>
> You probably want to mention which binding document defines the valid
> values for that property; ../gpio/led.txt I think.
>
Will add that also. Just an idea this is common for most of the leds cannot
this be put to some common place as reference
to avoid copying same text again?

>
> I wonder if we need to think about representing the blinking/fading/...
> capabilities of the chip too? Should that be encoded into the DT, or
> should it be controlled at run-time via some LED subsystem?
>
I think this is handled internally and current platform data doesn't have
support for that.

Thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

[-- Attachment #1.2: Type: text/html, Size: 2524 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss