From mboxrd@z Thu Jan 1 00:00:00 1970 From: Padma Venkat Subject: Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s Date: Fri, 21 Dec 2012 17:06:58 +0530 Message-ID: References: <1355395373-22058-1-git-send-email-padma.v@samsung.com> <1355395373-22058-3-git-send-email-padma.v@samsung.com> <20121219132414.2CF653E0AD7@localhost> <20121219170937.GV4985@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121219170937.GV4985-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Mark Brown Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Padmavathi Venna , sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lrg-l0cyMroinI0@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown wrote: > On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote: >> On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna wrote: > >> > +- compatible : "samsung,samsung-i2s" > >> Isn't that kind of redundant? :-) > >> The format of the compatible strings should be ",-i2s". >> Please be specific about the part number that you're doing the binding >> for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s". > > There are actually versioned IPs here (where the versions are used > publically in a few places) but it's not clearly documented which is > which. It would be reasonable to use the IP versions here I think. Samsung has three i2s drivers one for s3c24xx, one for s3c2412 and one for rest of the platforms. The above mentioned other platforms has Version 3/4/5 of i2s controllers. This dt binding is for for the i2s driver that has support for Version 3/4/5 of i2s controller. So "samsung,i2s-v5" is okay as compatible name? Please suggest me. Thanks Padma