devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Padma Venkat <padma.kvr@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Padmavathi Venna <padma.v@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	alsa-devel@alsa-project.org, sbkim73@samsung.com,
	Kukjin Kim <kgene.kim@samsung.com>,
	broonie@kernel.org, Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH V4 4/4] ARM: dts: add clock provider information for i2s controllers in Exynos5250
Date: Tue, 4 Jun 2013 09:58:30 +0530	[thread overview]
Message-ID: <CAAgF-Bd01JU_aess33d10ah7me=DR-tGF4vy20D6CPFiDYUg6g@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=X_XVmQ-jyorxATqBad5hhdFe5dodg_AzjsRQ-S+1=NeA@mail.gmail.com>

Hi Doug,

On Tue, Jun 4, 2013 at 1:48 AM, Doug Anderson <dianders@chromium.org> wrote:
> Padmavathi,
>
> On Sun, Jun 2, 2013 at 10:19 PM, Padmavathi Venna <padma.v@samsung.com> wrote:
>> +               clocks = <&clock_audss EXYNOS_I2S_BUS>,
>> +                       <&clock_audss EXYNOS_I2S_BUS>,
>> +                       <&clock_audss EXYNOS_SCLK_I2S>,
>> +                       <&clock_audss EXYNOS_MOUT_AUDSS>,
>> +                       <&clock_audss EXYNOS_MOUT_I2S>;
>> +               clock-names = "iis", "i2s_opclk0", "i2s_opclk1",
>> +                               "mout_audss", "mout_i2s";
>
> Are there bindings for these clocks? Would be nice to see a
> description for what they are supposed to be.

Yes. They have bindings. I will add the description.

>
> I looked up i2s_opclk0 / i2s_opclk1 and they look reasonable at a
> quick glance. ...and it does seem right that iis and i2s_opclk0 are
> the same. ...but I don't see any place that uses the last two. Is
> there an in-flight patch?

I don't have any patch for these right now. These are used internally.
But as these are i2s0 base clocks I added here.

>
> -Doug

Thanks
Padma

      reply	other threads:[~2013-06-04  4:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03  5:19 [PATCH V4 0/4] clk: Samsung: audss: Register audio subsytem clocks using common clk framework Padmavathi Venna
2013-06-03  5:19 ` [PATCH V4 1/4] ARM: samsung: use #include for all device trees Padmavathi Venna
2013-06-03  5:19 ` [PATCH V4 2/4] clk: samsung: register audio subsystem clocks using common clock framework Padmavathi Venna
2013-06-03 20:10   ` Doug Anderson
2013-06-03 23:46     ` Andrew Bresticker
2013-06-04  0:07       ` Doug Anderson
2013-06-03  5:19 ` [PATCH V4 3/4] ARM: dts: add Exynos audio subsystem clock controller node Padmavathi Venna
2013-06-03 20:13   ` Doug Anderson
2013-06-04  4:25     ` Padma Venkat
2013-06-04 15:15       ` Doug Anderson
2013-06-03  5:19 ` [PATCH V4 4/4] ARM: dts: add clock provider information for i2s controllers in Exynos5250 Padmavathi Venna
2013-06-03 20:18   ` Doug Anderson
2013-06-04  4:28     ` Padma Venkat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAgF-Bd01JU_aess33d10ah7me=DR-tGF4vy20D6CPFiDYUg6g@mail.gmail.com' \
    --to=padma.kvr@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dianders@chromium.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=padma.v@samsung.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).