From mboxrd@z Thu Jan 1 00:00:00 1970 From: Padma Venkat Subject: Re: [PATCH V4 4/4] ARM: dts: add clock provider information for i2s controllers in Exynos5250 Date: Tue, 4 Jun 2013 09:58:30 +0530 Message-ID: References: <1370236744-16802-1-git-send-email-padma.v@samsung.com> <1370236744-16802-5-git-send-email-padma.v@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Doug Anderson Cc: Padmavathi Venna , linux-samsung-soc , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , alsa-devel@alsa-project.org, sbkim73@samsung.com, Kukjin Kim , broonie@kernel.org, Mike Turquette List-Id: devicetree@vger.kernel.org Hi Doug, On Tue, Jun 4, 2013 at 1:48 AM, Doug Anderson wrote: > Padmavathi, > > On Sun, Jun 2, 2013 at 10:19 PM, Padmavathi Venna wrote: >> + clocks = <&clock_audss EXYNOS_I2S_BUS>, >> + <&clock_audss EXYNOS_I2S_BUS>, >> + <&clock_audss EXYNOS_SCLK_I2S>, >> + <&clock_audss EXYNOS_MOUT_AUDSS>, >> + <&clock_audss EXYNOS_MOUT_I2S>; >> + clock-names = "iis", "i2s_opclk0", "i2s_opclk1", >> + "mout_audss", "mout_i2s"; > > Are there bindings for these clocks? Would be nice to see a > description for what they are supposed to be. Yes. They have bindings. I will add the description. > > I looked up i2s_opclk0 / i2s_opclk1 and they look reasonable at a > quick glance. ...and it does seem right that iis and i2s_opclk0 are > the same. ...but I don't see any place that uses the last two. Is > there an in-flight patch? I don't have any patch for these right now. These are used internally. But as these are i2s0 base clocks I added here. > > -Doug Thanks Padma