Re: [PATCH V2 2/3] ARM: dts: add Exynos audio subsystem clock controller node

[Padma Venkat <padma.kvr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi Tomasz,

On Tue, May 7, 2013 at 3:24 PM, Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Hi Padmavathi,
>
> On Tuesday 07 of May 2013 12:13:35 Padmavathi Venna wrote:
>> Audio subsystem introduced in s5pv210 and exynos platforms
>> which has a internal clock controller. This patch adds a node
>> for the same on exynos5250.
>>
>> Signed-off-by: Padmavathi Venna <padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/exynos5250.dtsi |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi index 36c9d8d..7026de0 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -72,6 +72,12 @@
>>               #clock-cells = <1>;
>>       };
>>
>> +     clock_audss: audss-clock-controller@0x03810000 {
>
> Just a nitpick: this should be @3810000, without the 0x and leading zeroes.

Okey. I will change this.

>
> Best regards,
> --
> Tomasz Figa
> Samsung Poland R&D Center
> SW Solution Development, Kernel and System Framework
>
>> +             compatible = "samsung,exynos5250-audss-clock";
>> +             reg = <0x03810000 0x0C>;
>> +             #clock-cells = <1>;
>> +     };
>> +
>>       gic:interrupt-controller@10481000 {
>>               compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
>>               #interrupt-cells = <3>;
>
Thanks
Padma