From mboxrd@z Thu Jan 1 00:00:00 1970 From: Padma Venkat Subject: Re: [alsa-devel] [PATCH 1/2] ASOC: SAMSUNG: Add DT support for i2s Date: Wed, 1 Aug 2012 18:42:03 +0530 Message-ID: References: <1343218170-30483-1-git-send-email-padma.v@samsung.com> <1343218170-30483-2-git-send-email-padma.v@samsung.com> <08da01cd6fbf$cd9b5c00$68d21400$@com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <08da01cd6fbf$cd9b5c00$68d21400$@com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Sangbeom Kim Cc: Padmavathi Venna , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, rcsekar@samsung.com, sangsu4u.park@samsung.com, joshi@samsung.com, thutt@chromium.org, ben-linux@fluff.org, olofj@google.com List-Id: devicetree@vger.kernel.org Hi, On Wed, Aug 1, 2012 at 1:59 PM, Sangbeom Kim wrote: > Hi, > On Wednesday, July 25, 2012 9:09 PM, Padmavathi Venna wrote: > >> Add support for device based discovery. >> > Currently, I'm reviewing your patch set. > Your patch can support device tree for Samsung's i2s. > But I wonder that Your patch can support non-dt too, > So, Please test your patch on non-dt environment. > It looks unclear handling of clock source. > After code review, I will give you more detail comments, Okey. I will test these patches in non-dt environment. > > Thanks, > Sangbeom. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html