Re: [PATCH v3 1/5] soc: loongson: loongson2_pm: Add dependency for INPUT

[Huacai Chen <chenhuacai@kernel.org>]

Hi, Conor,

On Tue, Sep 19, 2023 at 11:48 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Sep 19, 2023 at 08:36:50AM -0700, Randy Dunlap wrote:
> > Hi--
> >
> > On 9/2/23 08:43, Randy Dunlap wrote:
> > >
> > >
> > > On 9/2/23 01:47, Binbin Zhou wrote:
> > >> Since commit 67694c076bd7 ("soc: loongson2_pm: add power management
> > >> support"), the Loongson-2K PM driver was added, but it didn't update the
> > >> Kconfig entry for the INPUT dependency, leading to build errors:
> > >>
> > >> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> > >> drivers/soc/loongson/loongson2_pm.o: in function `loongson2_power_button_init':
> > >> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:101:(.text+0x350): undefined reference to `input_allocate_device'
> > >> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> > >> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:109:(.text+0x3dc): undefined reference to `input_set_capability'
> > >> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> > >> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:111:(.text+0x3e4): undefined reference to `input_register_device'
> > >> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> > >> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:125:(.text+0x3fc): undefined reference to `input_free_device'
> > >> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key':
> > >> /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x58c): undefined reference to `input_event'
> > >>
> > >> Also, since this driver can only be built-in, it fails to link when the
> > >> INPUT is in a loadable module, so we should update the Kconfig entry to
> > >> depend on INPUT=y.
> > >>
> > >> Fixes: 67694c076bd7 ("soc: loongson2_pm: add power management support")
> > >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > >> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > >
> > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> > > Tested-by: Randy Dunlap <rdunlap@infradead.org>
> > >
> > > Thanks.
> >
> > What's the status of this patch?
> > linux-next builds are still failing without this patch.
>
> Likely suffering (still) from:
>
> https://lore.kernel.org/all/58500dc7-af1b-4edb-bb2b-93be454ec151@app.fastmail.com/
>
> :)
>
> Seemingly this was sent again in isolation 2 weeks ago, but neither the
> maintainer (Huacai) nor soc@kernel.org were on cc:
>
> https://lore.kernel.org/all/20230905123629.4510-1-zhuyinbo@loongson.cn/
v3 indeed cc-ed soc@kernel.org. :)

Arnd, could you please take this series to the soc tree? And also this series:
https://lore.kernel.org/loongarch/cover.1693534134.git.zhoubinbin@loongson.cn/T/#t

Thanks,
Huacai

>
> /shrug
> Conor.
>
> >
> > Thanks.
> >
> > >
> > >> ---
> > >>  drivers/soc/loongson/Kconfig | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/soc/loongson/Kconfig b/drivers/soc/loongson/Kconfig
> > >> index 314e13bb3e01..368344943a93 100644
> > >> --- a/drivers/soc/loongson/Kconfig
> > >> +++ b/drivers/soc/loongson/Kconfig
> > >> @@ -20,6 +20,7 @@ config LOONGSON2_GUTS
> > >>  config LOONGSON2_PM
> > >>    bool "Loongson-2 SoC Power Management Controller Driver"
> > >>    depends on LOONGARCH && OF
> > >> +  depends on INPUT=y
> > >>    help
> > >>      The Loongson-2's power management controller was ACPI, supports ACPI
> > >>      S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
> > >
> >
> > --
> > ~Randy