From: Moritz Fischer <moritz.fischer@ettus.com>
To: atull <atull@opensource.altera.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Matthew Gerlach <mgerlach@altera.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Rob Herring <robh+dt@kernel.org>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Alan Tull <delicious.quinoa@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support
Date: Mon, 8 Aug 2016 13:44:59 -0700 [thread overview]
Message-ID: <CAAtXAHev2Dytadp-_Hs0agcSXUTyrFhJQxHcsFd7faOReHzr9Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1608081416110.11063@linuxheads99>
Hi Alan,
On Mon, Aug 8, 2016 at 12:18 PM, atull <atull@opensource.altera.com> wrote:
>> Please don't use module.h in drivers controlled by a bool
>> Kconfig setting.
>>
>> THanks,
>> Paul.
>>
>
> Thanks for the feedback. Can you provide an example of what you
> would consider to be proper usage in the kernel?
I think Paul is suggesting to use
static int __init alt_fpga_bridge_init(void)
{
platform_driver_register(&alt_fpga_bridge_driver);
}
device_initcall(alt_fpga_bridge_init);
or better:
builtin_platform_driver(&alt_fpga_bridge_driver);
Like for example in: drivers/cpuidle/cpuidle-mvebu-v7.c
Cheers,
Moritz
next prev parent reply other threads:[~2016-08-08 20:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 19:36 [PATCH v18 0/6] Device Tree support for FPGA Programming Alan Tull
2016-07-12 19:36 ` [PATCH v18 1/6] fpga: add bindings document for fpga region Alan Tull
2016-07-21 19:39 ` Rob Herring
2016-07-12 19:36 ` [PATCH v18 2/6] ARM: socfpga: add bindings document for fpga bridge drivers Alan Tull
[not found] ` <20160712193645.9098-3-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-08-01 16:18 ` Rob Herring
2016-08-03 18:44 ` atull
2016-07-12 19:36 ` [PATCH v18 3/6] add sysfs document for fpga bridge class Alan Tull
2016-07-12 19:36 ` [PATCH v18 4/6] fpga: add fpga bridge framework Alan Tull
2016-07-14 20:54 ` Paul Gortmaker
[not found] ` <CAP=VYLpxK7qt25pmC2byYRm1zVbVrkf2f1+xctoSTSAy+n9QdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-15 16:58 ` Alan Tull
2016-07-12 19:36 ` [PATCH v18 5/6] fpga: fpga-region: device tree control for FPGA Alan Tull
2016-07-12 19:36 ` [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support Alan Tull
2016-07-14 20:47 ` Paul Gortmaker
2016-08-08 19:18 ` atull
2016-08-08 20:44 ` Moritz Fischer [this message]
2016-08-09 16:00 ` Paul Gortmaker
2016-09-22 19:53 ` atull
2016-09-23 14:13 ` Steffen Trumtrar
2016-07-12 19:43 ` [PATCH v18 0/6] Device Tree support for FPGA Programming atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAtXAHev2Dytadp-_Hs0agcSXUTyrFhJQxHcsFd7faOReHzr9Q@mail.gmail.com \
--to=moritz.fischer@ettus.com \
--cc=atull@opensource.altera.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgerlach@altera.com \
--cc=paul.gortmaker@windriver.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).