devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Steev Klimaszewski <steev@kali.org>
Cc: Johan Hovold <johan@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Sven Peter <sven@svenpeter.dev>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-bluetooth@vger.kernel.org,
	Mark Pearson <markpearson@lenovo.com>,
	Tim Jiang <quic_tjiang@quicinc.com>
Subject: Re: [PATCH v8 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855
Date: Wed, 12 Apr 2023 13:00:44 -0700	[thread overview]
Message-ID: <CABBYNZKX9bixyy8GZ0VDFaeNeY0_MSVDDNvcTqiAXEx8zFXfbA@mail.gmail.com> (raw)
In-Reply-To: <CAKXuJqjJjd6SY1g3JW8w53rEVCqgDkJXQ=1iA3qXcF+C9qv1SQ@mail.gmail.com>

Hi Steev,

On Thu, Mar 30, 2023 at 9:35 AM Steev Klimaszewski <steev@kali.org> wrote:
>
> Hi Johan,
>
> On Thu, Mar 30, 2023 at 5:10 AM Johan Hovold <johan@kernel.org> wrote:
> >
> > On Sun, Mar 26, 2023 at 06:38:10PM -0500, Steev Klimaszewski wrote:
> > > Add regulators, GPIOs and changes required to power on/off wcn6855.
> > > Add support for firmware download for wcn6855 which is in the
> > > linux-firmware repository as hpbtfw21.tlv and hpnv21.bin.
> > >
> > > Based on the assumption that this is similar to the wcn6750
> > >
> > > Tested-on: BTFW.HSP.2.1.0-00538-VER_PATCHZ-1
> > >
> > > Signed-off-by: Steev Klimaszewski <steev@kali.org>
> > > Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> > > Tested-by: Bjorn Andersson <andersson@kernel.org>
> > > ---
> > > Changes since v7:
> > >  * None
> >
> > Only noticed now when Luiz applied the patches, but why did you drop my
> > reviewed-by and tested-by tags from this patch when submitting v8?
> >
> > For the record:
> >
> > Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> > Tested-by: Johan Hovold <johan+linaro@kernel.org>
> >
> Oops, that wasn't intentional! I only meant to drop it on the dts bits
> as that part I wanted to make sure I got right based on your comments,
> my apologies!
> --steev

This one seems to be causing a new warning:

drivers/bluetooth/hci_qca.c:18
94:37: warning: unused variable 'qca_soc_data_wcn6855' [-Wunused-const-variable]

-- 
Luiz Augusto von Dentz

  reply	other threads:[~2023-04-12 20:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26 23:38 [PATCH v8 0/4] Add WCN6855 Bluetooth support Steev Klimaszewski
2023-03-26 23:38 ` [PATCH v8 1/4] dt-bindings: net: Add WCN6855 Bluetooth Steev Klimaszewski
2023-03-26 23:38 ` [PATCH v8 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855 Steev Klimaszewski
2023-03-30 10:10   ` Johan Hovold
2023-03-30 16:35     ` Steev Klimaszewski
2023-04-12 20:00       ` Luiz Augusto von Dentz [this message]
2023-04-12 23:38         ` Steev Klimaszewski
2023-03-26 23:38 ` [PATCH v8 3/4] arm64: dts: qcom: sc8280xp: Define uart2 Steev Klimaszewski
2023-03-26 23:38 ` [PATCH v8 4/4] arm64: dts: qcom: sc8280xp-x13s: Add bluetooth Steev Klimaszewski
2023-03-28 22:24   ` Luiz Augusto von Dentz
2023-03-29  0:26     ` Steev Klimaszewski
2023-03-29  0:38     ` Konrad Dybcio
2023-03-29  6:40     ` Johan Hovold
2023-03-29  7:26     ` Krzysztof Kozlowski
2023-03-29  6:44   ` Johan Hovold
2023-03-29 19:50 ` [PATCH v8 0/4] Add WCN6855 Bluetooth support patchwork-bot+bluetooth
2023-04-05  4:09 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABBYNZKX9bixyy8GZ0VDFaeNeY0_MSVDDNvcTqiAXEx8zFXfbA@mail.gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=johan@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=markpearson@lenovo.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_tjiang@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=steev@kali.org \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).