From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B239ECAAD6 for ; Fri, 26 Aug 2022 06:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245010AbiHZGc5 (ORCPT ); Fri, 26 Aug 2022 02:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245009AbiHZGc4 (ORCPT ); Fri, 26 Aug 2022 02:32:56 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A813D11CE for ; Thu, 25 Aug 2022 23:32:53 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z6so764967lfu.9 for ; Thu, 25 Aug 2022 23:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=+qU9ctcrY7mtJ7WOAIohkf0A848XGp2YRevCX8i4gts=; b=C7HaYeqFpX0lS9ll1R6ZCwBkm8QpDYZfuNWeuq8t0XEvQUmiGWlAwZ92EXwJeoD4J+ HhrTOmbUp2lx/PBx34u5s9RtG5xGwYCqitwzWsE9tNWsKG4h4D9o4WCojuyM8IRP0AvA 2Q3oTSAcRaBDuC05Vpm59LuL+Js5fRXqt+8lY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=+qU9ctcrY7mtJ7WOAIohkf0A848XGp2YRevCX8i4gts=; b=cTOqGxnlut+tCUkZF/NS1gp0DV0JPzE9trypCHBZf26OfAxHYU8OU2QInw7wPCmN+U tct+Nt5b4BLCbRZOA+OqV0CB5ffC2+yjHKiFYMkM4XKdRHheyxPvg37ZhdJMpLk1HMFp vZRK1662h6UolNwwXY316Htdq77zQqIdAUre839xZknih7nYCwHlEyKzGqnPYj/yI/zg eduoXHekIOeFbWg2p8+v/zWoxPGPv0wdHPzqElYOky1AHz5qABnpMlM6nUxVgGpl0fwV eVKnt9Lv6lCe8RaShn2GPZ5LWfKKEvQRhwXY1ubuT7zRAs3Pse3Bw1iZKWx4qWdSGGXe pT/A== X-Gm-Message-State: ACgBeo1ultnm+ibJbs/IuECa83ZJDblg1avYsiwa6de2ih3dKwL41Lmp o/OtaE/3SC9novp/67U28WIpupecFEIIYphhOjQmpN/2Sk3F9Q== X-Google-Smtp-Source: AA6agR6XzaZ+tjS2B38+xX/5fv3zVFoMbmEjVYn3rbhESLg5eHnuuhXweWowUZRe3isFIyyq67NglnbcGPdP3p8ht3c= X-Received: by 2002:a05:6512:1694:b0:48a:9d45:763f with SMTP id bu20-20020a056512169400b0048a9d45763fmr1987125lfb.662.1661495571621; Thu, 25 Aug 2022 23:32:51 -0700 (PDT) MIME-Version: 1.0 References: <20220820082936.686924-1-dario.binacchi@amarulasolutions.com> <20220820082936.686924-4-dario.binacchi@amarulasolutions.com> In-Reply-To: From: Dario Binacchi Date: Fri, 26 Aug 2022 08:32:40 +0200 Message-ID: Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4 To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Alexandre Torgue , Amarula patchwork , Marc Kleine-Budde , michael@amarulasolutions.com, Dario Binacchi , Krzysztof Kozlowski , Maxime Coquelin , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Tue, Aug 23, 2022 at 3:43 PM Krzysztof Kozlowski wrote: > > On 20/08/2022 11:29, Dario Binacchi wrote: > > Add pin configurations for using CAN controller on stm32f469-disco > > board. They are located on the Arduino compatible connector CN5 (CAN1) > > and on the extension connector CN12 (CAN2). > > > > Signed-off-by: Dario Binacchi > > Signed-off-by: Dario Binacchi > > Do not ignore review. This is not correct. You are mixing copyright with > SoC... OK. I got it. I will drop one SOB in version 3. > > > > > > > + can2_pins_b: can2-1 { > > + pins1 { > > + pinmux = ; /* CAN2_TX */ > > + }; > > + pins2 { > > + pinmux = ; /* CAN2_RX */ > > + bias-pull-up; > > + }; > > + }; > > + > > Don't ignore review. Sorry, I didn't want to ignore your review, I thought the blank line to be removed was another. Actually I had to remove two blank lines and I left out the one you suggested. Thanks and regards, Dario > > That's second one, so that's a no.. :( > > Best regards, > Krzysztof -- Dario Binacchi Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com