* [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support
@ 2013-04-19 13:38 Michal Bachraty
2013-04-19 17:36 ` Daniel Mack
2013-04-23 13:49 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Michal Bachraty @ 2013-04-19 13:38 UTC (permalink / raw)
To: perex, tiwai, grant.likely, rob.herring, alsa-devel, linux-kernel,
devicetree-discuss
Cc: marek.belisko, broonie, lgirdwood, Michal Bachraty
Add devicetree support for this dummy audio soc driver.
Signed-off-by: Michal Bachraty <michal.bachraty@streamunlimited.com>
---
sound/soc/codecs/spdif_transciever.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/codecs/spdif_transciever.c b/sound/soc/codecs/spdif_transciever.c
index 112a49d..4c8c295 100644
--- a/sound/soc/codecs/spdif_transciever.c
+++ b/sound/soc/codecs/spdif_transciever.c
@@ -20,6 +20,7 @@
#include <sound/soc.h>
#include <sound/pcm.h>
#include <sound/initval.h>
+#include <linux/of.h>
#define DRV_NAME "spdif-dit"
@@ -52,12 +53,21 @@ static int spdif_dit_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_OF
+static const struct of_device_id spdif_dit_dt_ids[] = {
+ { .compatible = DRV_NAME, },
+ { }
+};
+MODULE_DEVICE_TABLE(of, spdif_dits_dt_ids);
+#endif
+
static struct platform_driver spdif_dit_driver = {
.probe = spdif_dit_probe,
.remove = spdif_dit_remove,
.driver = {
.name = DRV_NAME,
.owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(spdif_dit_dt_ids),
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support
2013-04-19 13:38 [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support Michal Bachraty
@ 2013-04-19 17:36 ` Daniel Mack
2013-04-23 14:02 ` Sebastian Hesselbarth
2013-04-23 13:49 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Mack @ 2013-04-19 17:36 UTC (permalink / raw)
To: Michal Bachraty
Cc: alsa-devel, lgirdwood, tiwai, devicetree-discuss, broonie,
linux-kernel, rob.herring, grant.likely, marek.belisko
Hi Michal,
On 19.04.2013 15:38, Michal Bachraty wrote:
> Add devicetree support for this dummy audio soc driver.
I think Mark wants to see only "ASoC:" in the patch subjects now.
>
> Signed-off-by: Michal Bachraty <michal.bachraty@streamunlimited.com>
> ---
> sound/soc/codecs/spdif_transciever.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/codecs/spdif_transciever.c b/sound/soc/codecs/spdif_transciever.c
> index 112a49d..4c8c295 100644
> --- a/sound/soc/codecs/spdif_transciever.c
> +++ b/sound/soc/codecs/spdif_transciever.c
> @@ -20,6 +20,7 @@
> #include <sound/soc.h>
> #include <sound/pcm.h>
> #include <sound/initval.h>
> +#include <linux/of.h>
>
> #define DRV_NAME "spdif-dit"
>
> @@ -52,12 +53,21 @@ static int spdif_dit_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id spdif_dit_dt_ids[] = {
> + { .compatible = DRV_NAME, },
I think this needs a "linux," prefix. Just put the whole string here.
Same goes for the patch against the spdif_receiver driver.
Thanks,
Daniel
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, spdif_dits_dt_ids);
> +#endif
> +
> static struct platform_driver spdif_dit_driver = {
> .probe = spdif_dit_probe,
> .remove = spdif_dit_remove,
> .driver = {
> .name = DRV_NAME,
> .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(spdif_dit_dt_ids),
> },
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support
2013-04-19 13:38 [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support Michal Bachraty
2013-04-19 17:36 ` Daniel Mack
@ 2013-04-23 13:49 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-04-23 13:49 UTC (permalink / raw)
To: Michal Bachraty
Cc: perex, tiwai, grant.likely, rob.herring, alsa-devel, linux-kernel,
devicetree-discuss, lgirdwood, marek.belisko
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Fri, Apr 19, 2013 at 03:38:45PM +0200, Michal Bachraty wrote:
> Add devicetree support for this dummy audio soc driver.
>
> Signed-off-by: Michal Bachraty <michal.bachraty@streamunlimited.com>
> ---
> sound/soc/codecs/spdif_transciever.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
New device tree bindings need a binding document.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support
2013-04-19 17:36 ` Daniel Mack
@ 2013-04-23 14:02 ` Sebastian Hesselbarth
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Hesselbarth @ 2013-04-23 14:02 UTC (permalink / raw)
To: Daniel Mack
Cc: Michal Bachraty, alsa-devel, lgirdwood, tiwai, devicetree-discuss,
Mark Brown, linux-kernel, Rob Herring, perex, marek.belisko
On Fri, Apr 19, 2013 at 7:36 PM, Daniel Mack <zonque@gmail.com> wrote:
> Hi Michal,
>
> On 19.04.2013 15:38, Michal Bachraty wrote:
>> Add devicetree support for this dummy audio soc driver.
>
> I think Mark wants to see only "ASoC:" in the patch subjects now.
>
>>
>> Signed-off-by: Michal Bachraty <michal.bachraty@streamunlimited.com>
>> ---
>> sound/soc/codecs/spdif_transciever.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/sound/soc/codecs/spdif_transciever.c b/sound/soc/codecs/spdif_transciever.c
>> index 112a49d..4c8c295 100644
>> --- a/sound/soc/codecs/spdif_transciever.c
>> +++ b/sound/soc/codecs/spdif_transciever.c
>> @@ -20,6 +20,7 @@
>> #include <sound/soc.h>
>> #include <sound/pcm.h>
>> #include <sound/initval.h>
>> +#include <linux/of.h>
>>
>> #define DRV_NAME "spdif-dit"
>>
>> @@ -52,12 +53,21 @@ static int spdif_dit_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id spdif_dit_dt_ids[] = {
>> + { .compatible = DRV_NAME, },
>
> I think this needs a "linux," prefix. Just put the whole string here.
Michal,
I suggest to also rename spdif_transceiver to spdif_transmitter, as
"transceiver"
usually do both "transmit" and "receive". I don't know who made up the current
name, but the driver is definitely a transmitter.
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-23 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 13:38 [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support Michal Bachraty
2013-04-19 17:36 ` Daniel Mack
2013-04-23 14:02 ` Sebastian Hesselbarth
2013-04-23 13:49 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).