From: Dzmitry Sankouski <dsankouski@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 08/12] arm64: dts: qcom: sdm845-starqltechn: add display PMIC
Date: Mon, 2 Dec 2024 16:18:00 +0300 [thread overview]
Message-ID: <CABTCjFAUp9Oa_qRweO-EpLHDTi78=07i_St+L9EDSgYxHMrc4w@mail.gmail.com> (raw)
In-Reply-To: <ee668cbf-54e0-4c0a-b690-8606cb3785b7@oss.qualcomm.com>
пн, 4 нояб. 2024 г. в 17:15, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>:
>
> On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote:
> > Add support for s2dos05 display / touchscreen PMIC
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> > ---
> > Changes in v6:
> > - refactor: s/starqltechn/sdm845-starqltechn in subject
> > - refactor: 'i' < 'm', so put tlmm i2c node before motor*
>
> Now you have 'i'2c21 before 'g'pio-regulator :/
That refactor was about tlmm inner nodes. For soc nodes
rule `nodes of the same type can be grouped together` should apply I guess.
I think I should move it to regulators.
> [...]
>
> >
> > + i2c21 {
> > + compatible = "i2c-gpio";
>
> I'm not sure this has been asked before - is the GENI SE for I2C21
> disabled? Or are there reasons to use i2c-gpio instead?
>
I2c21 is wired on pins 127, 128, and those pins don't have a GENI SE function.
--
Best regards and thanks for review,
Dzmitry
next prev parent reply other threads:[~2024-12-02 13:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 16:51 [PATCH v6 00/12] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 01/12] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
2024-10-26 10:20 ` Konrad Dybcio
2024-10-08 16:51 ` [PATCH v6 02/12] arm64: dts: qcom: sdm845-starqltechn: remove wifi Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 03/12] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake Dzmitry Sankouski
2024-10-26 10:41 ` Konrad Dybcio
2024-12-02 13:41 ` Dzmitry Sankouski
2024-12-02 15:09 ` Konrad Dybcio
2024-12-02 20:10 ` Dzmitry Sankouski
2024-12-05 16:41 ` Konrad Dybcio
2024-10-08 16:51 ` [PATCH v6 04/12] arm64: dts: qcom: sdm845-starqltechn: refactor node order Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 05/12] arm64: dts: qcom: sdm845-starqltechn: remove excess reserved gpios Dzmitry Sankouski
2024-10-26 10:21 ` Konrad Dybcio
2024-10-08 16:51 ` [PATCH v6 06/12] arm64: dts: qcom: sdm845-starqltechn: add gpio keys Dzmitry Sankouski
2024-10-26 10:38 ` Konrad Dybcio
2024-12-02 10:58 ` Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 07/12] arm64: dts: qcom: sdm845-starqltechn: add max77705 PMIC Dzmitry Sankouski
2024-10-26 10:36 ` Konrad Dybcio
2024-12-02 10:45 ` Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 08/12] arm64: dts: qcom: sdm845-starqltechn: add display PMIC Dzmitry Sankouski
2024-11-04 14:15 ` Konrad Dybcio
2024-12-02 13:18 ` Dzmitry Sankouski [this message]
2024-12-02 15:01 ` Konrad Dybcio
2024-12-02 13:25 ` Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 09/12] arm64: dts: qcom: sdm845-starqltechn: add touchscreen support Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 10/12] arm64: dts: qcom: sdm845-starqltechn: add initial sound support Dzmitry Sankouski
2024-10-26 10:32 ` Konrad Dybcio
2024-12-02 11:43 ` Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 11/12] arm64: dts: qcom: sdm845-starqltechn: add graphics support Dzmitry Sankouski
2024-10-08 16:51 ` [PATCH v6 12/12] arm64: dts: qcom: sdm845-starqltechn: add modem support Dzmitry Sankouski
2024-10-26 10:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABTCjFAUp9Oa_qRweO-EpLHDTi78=07i_St+L9EDSgYxHMrc4w@mail.gmail.com' \
--to=dsankouski@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).