Re: [PATCH v11 2/2] arm64: dts: qcom: sagit: add initial device tree for sagit

[Dzmitry Sankouski <dsankouski@gmail.com>]

Is the master branch of
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
proper rebase?
Or do I need to search and apply device tree doc patches somehow
before running dtbs_check?
I rebased on linux-next/master, and my dts is ok.

A lot of warnings for msm8998.dtsi, though. I think it should be fixed
in a separate patch series.

ср, 2 нояб. 2022 г. в 22:20, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org>:
>
> On 02/11/2022 11:55, Dzmitry Sankouski wrote:
> > New device support - Xiaomi Mi6 phone
> >
> > What works:
> > - storage
> > - usb
> > - power regulators
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> > ---
>
> (...)
>
> > +
> > +&blsp1_i2c5_sleep {
> > +     /delete-property/ bias-pull-up;
> > +     bias-disable;
> > +};
> > +
> > +&blsp1_uart3 {
> > +     status = "okay";
> > +
> > +     bluetooth {
> > +             compatible = "qcom,wcn3990-bt";
> > +
> > +             vddio-supply = <&vreg_s4a_1p8>;
> > +             vddxo-supply = <&vreg_l7a_1p8>;
> > +             vddrf-supply = <&vreg_l17a_1p3>;
> > +             vddch0-supply = <&vreg_l25a_3p3>;
> > +             max-speed = <3200000>;
> > +     };
> > +};
> > +
> > +&blsp1_uart3_on {
> > +     rx {
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> 6.1-rc3 is not a proper rebase... You *must* include maintainers'
> entries. This *must* align with stuff has Bjorn. Also I expect it passes
> dtbs_check on stuff in the next.
>
> Best regards,
> Krzysztof
>