From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 01/15] phy: rockchip-emmc: give DLL some extra time to be ready Date: Mon, 20 Jun 2016 12:36:37 -0700 Message-ID: References: <1466445414-11974-1-git-send-email-dianders@chromium.org> <1466445414-11974-2-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Doug Anderson Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ulf Hansson , Ziyuan Xu , Heiko Stuebner , Shawn Lin , Brian Norris , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Adrian Hunter , "open list:ARM/Rockchip SoC..." , Rob Herring , Guenter Roeck , Kishon Vijay Abraham I , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Jun 20, 2016 at 12:30 PM, Doug Anderson wrote: > Hi, > > On Mon, Jun 20, 2016 at 12:23 PM, Guenter Roeck wrote: >> On Mon, Jun 20, 2016 at 10:56 AM, Douglas Anderson >> wrote: >>> From: Shawn Lin >>> >>> According to the databook, 10.2us is the max time for dll to be ready to >>> work. However in testing, some chips need 20us for dll to be ready. This >> >> Nitpick, but description (20uS) and code (more than 25 uS) don't match. > > Good catch. If I spin the series I'll fix this, otherwise I'll assume > that the person applying this (Ulf?) can fix the description at their > discretion. > Not that it matters much, as the code is replaced in a later patch anyway. It might make more sense to merge the two patches into one. Guenter