devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anil Kumar <anilk4.v-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
Cc: Alsa Devel List
	<alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	thomas-xePHB1Atl/Dsq35pWSNszA@public.gmane.org
Subject: Re: [PATCH V2] ARM: dts: omap3-devkit8000: Enable audio support
Date: Wed, 27 Feb 2013 08:12:52 +0530	[thread overview]
Message-ID: <CABYxbz5izBpc96EG++Qa2dZM3XCFeygQ-d8TOdEVw0DCeT6Qsg@mail.gmail.com> (raw)
In-Reply-To: <51220E78.5000409-l0cyMroinI0@public.gmane.org>

Hi,

On Mon, Feb 18, 2013 at 4:50 PM, Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> wrote:
> On 02/16/2013 08:33 AM, Anil Kumar wrote:
>> Add the needed sections to enable audio support on
>> Devkit8000 when booted with DT blob.
>>
>> Signed-off-by: Anil Kumar <anilk4.v-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Looks good:
> Acked-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>

Gentle Ping. As there are no review comments on this patch,
Could you please pull this patch ?

Thanks,
Anil
>
>> ---
>> This patch is based on top of kernel 3.8-rc5 and
>> the following patches.
>>
>> Peter Ujfalusi:-
>> ASoC: twl4030: Correct the support for Voice port
>> ASoC: twl4030: Convert MICBIAS to SUPPLY widget
>> ASoC: omap-twl4030: Add support for routing, voice port and jack detect
>>
>> Anil Kumar:-
>> ARM: dts: add minimal DT support for DevKit8000
>> https://patchwork.kernel.org/patch/2122461/
>>
>> -Tested for playback and capture on Devkit8000.
>>
>>  Test process:-
>>
>>  #amixer set 'PredriveR Mixer AudioR2' on
>>  #amixer set 'PredriveL Mixer AudioL2' on
>>  #amixer set PreDriv 100 unmute
>>  #amixer set 'DAC2 Digital Fine' 100
>>  #amixer cset numid=27 1
>>  #arecord | aplay
>>
>> For V2:
>>  - Remove pin mux as done at device boot time by default.
>>
>> :100644 100644 6338993... c70116f... M        arch/arm/boot/dts/omap3-devkit8000.dts
>>  arch/arm/boot/dts/omap3-devkit8000.dts |   23 +++++++++++++++++++----
>>  1 files changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
>> index 6338993..c70116f 100644
>> --- a/arch/arm/boot/dts/omap3-devkit8000.dts
>> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
>> @@ -42,6 +42,19 @@
>>                  };
>>
>>       };
>> +
>> +     sound {
>> +             compatible = "ti,omap-twl4030";
>> +             ti,model = "devkit8000";
>> +
>> +             ti,mcbsp = <&mcbsp2>;
>> +             ti,codec = <&twl_audio>;
>> +             ti,audio-routing =
>> +                     "Ext Spk", "PREDRIVEL",
>> +                     "Ext Spk", "PREDRIVER",
>> +                     "MAINMIC", "Main Mic",
>> +                     "Main Mic", "Mic Bias 1";
>> +     };
>>  };
>>
>>  &i2c1 {
>> @@ -51,6 +64,12 @@
>>               reg = <0x48>;
>>               interrupts = <7>;       /* SYS_NIRQ cascaded to intc */
>>               interrupt-parent = <&intc>;
>> +
>> +             twl_audio: audio {
>> +                     compatible = "ti,twl4030-audio";
>> +                     codec {
>> +                     };
>> +             };
>>       };
>>  };
>>
>> @@ -86,10 +105,6 @@
>>       status = "disabled";
>>  };
>>
>> -&mcbsp2 {
>> -     status = "disabled";
>> -};
>> -
>>  &mcbsp3 {
>>       status = "disabled";
>>  };
>>
>
>
> --
> Péter

      parent reply	other threads:[~2013-02-27  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16  7:33 [PATCH V2] ARM: dts: omap3-devkit8000: Enable audio support Anil Kumar
2013-02-18 11:20 ` Peter Ujfalusi
     [not found]   ` <51220E78.5000409-l0cyMroinI0@public.gmane.org>
2013-02-27  2:42     ` Anil Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABYxbz5izBpc96EG++Qa2dZM3XCFeygQ-d8TOdEVw0DCeT6Qsg@mail.gmail.com \
    --to=anilk4.v-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
    --cc=thomas-xePHB1Atl/Dsq35pWSNszA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).