From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jassi Brar Subject: Re: [PATCH 1/8] mailbox: introduce ARM SMC based mailbox Date: Mon, 24 Jul 2017 23:22:41 +0530 Message-ID: References: <20170630095608.24943-1-andre.przywara@arm.com> <20170630095608.24943-2-andre.przywara@arm.com> <22d23c1d-ea8d-9829-4624-6305cd83ad4a@arm.com> <0aaba7fb-2183-2d4d-ba04-64b30cd0ae10@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0aaba7fb-2183-2d4d-ba04-64b30cd0ae10@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sudeep Holla Cc: Mark Rutland , Devicetree List , =?UTF-8?Q?Andr=C3=A9_Przywara?= , Chen-Yu Tsai , Linux Kernel Mailing List , linux-sunxi@googlegroups.com, Rob Herring , Icenowy Zheng , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Mon, Jul 24, 2017 at 11:08 PM, Sudeep Holla wrote: > On 24/07/17 18:20, Jassi Brar wrote: >> >>> I see that the SCPI firmware driver (as the user of the mailbox API) is >>> expecting the return value from a0 as returned above, translating the >>> firmware error codes into Linux' ones. >>> >> I am afraid, SCPI driver is not the golden example for client drivers >> to follow. It is supposed to work only with MHU, and then, it is >> likely to break if some other protocol is running parallel to it. >> > > Not sure why do you say it works only with ARM MHU ? AmLogic uses it > with their mailbox driver. However they followed an interim version of > the SCPI spec which is termed "legacy" in the driver. > Screw coding... Just tell me what stuff do you smoke? Must be really good!