From: Jassi Brar <jassisinghbrar@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
"A.s. Dong" <aisheng.dong@nxp.com>,
Devicetree List <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, ",
linux-arm-kernel"@lists.infradead.org,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>, ",
Sascha Hauer" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>, ",
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
srv_heupstream" <linux-mediatek@lists.infradead.org>,
Shawn Guo <shawnguo@kernel.org>srv_heupstream
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit
Date: Thu, 26 Jul 2018 16:39:34 +0530 [thread overview]
Message-ID: <CABb+yY2=mFr+gFuWyE+VyG6dWj3gKhTs6X+U9UjFu5N=4zU5uA@mail.gmail.com> (raw)
In-Reply-To: <a988e8b4-28be-f598-82de-421017409368@pengutronix.de>
On Thu, Jul 26, 2018 at 4:21 PM, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>>
>>> +struct imx_mu_con_priv {
>>> + int irq;
>>> + unsigned int idx;
>>> + char *irq_desc;
>>>
>> Having char irq_desc[16]; seems simpler than free/kfree upon
>> each startup/shutdown. Simply use snprintf() in probe().
>
> Currently all known configurations use one or two channels. I don't see
> any sense to allocate all at the probe.
>
Just because only 2 out of 4 channels are being used, it doesn't make sense?
What is the concern? "wasting" 16x2 bytes of memory? How many bytes,
LOC and execution time does kasprintf() waste?
next prev parent reply other threads:[~2018-07-26 11:09 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 6:53 [PATCH v7 0/6] add mailbox support for i.MX7D Oleksij Rempel
2018-07-26 6:53 ` [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0 Oleksij Rempel
2018-07-26 9:41 ` Jassi Brar
2018-07-26 11:00 ` A.s. Dong
2018-07-26 11:36 ` Jassi Brar
2018-07-26 11:55 ` A.s. Dong
2018-07-26 12:04 ` Jassi Brar
2018-07-26 6:53 ` [PATCH v7 2/6] dt-bindings: arm: fsl: add mu binding doc Oleksij Rempel
2018-07-26 9:56 ` Jassi Brar
2018-07-26 6:53 ` [PATCH v7 3/6] dt-bindings: mailbox: imx-mu: add generic MU channel support Oleksij Rempel
2018-07-26 9:49 ` Jassi Brar
2018-07-26 10:57 ` Oleksij Rempel
2018-07-26 11:28 ` Jassi Brar
2018-07-26 11:51 ` A.s. Dong
2018-07-26 12:26 ` Jassi Brar
2018-07-26 13:34 ` A.s. Dong
2018-07-26 13:49 ` Jassi Brar
2018-07-26 14:13 ` A.s. Dong
2018-07-26 15:44 ` Jassi Brar
2018-07-27 4:02 ` A.s. Dong
2018-07-27 4:55 ` Jassi Brar
2018-07-27 6:00 ` A.s. Dong
2018-07-27 6:46 ` Jassi Brar
2018-07-27 8:42 ` A.s. Dong
2018-07-27 9:05 ` A.s. Dong
2018-07-28 13:09 ` Jassi Brar
2018-07-30 7:35 ` Oleksij Rempel
2018-07-30 8:42 ` A.s. Dong
2018-07-30 13:04 ` Jassi Brar
2018-07-30 14:14 ` A.s. Dong
2018-07-30 14:27 ` A.s. Dong
2018-07-30 14:17 ` A.s. Dong
2018-07-30 14:44 ` Oleksij Rempel
2018-07-30 15:02 ` Jassi Brar
2018-07-30 15:36 ` A.s. Dong
2018-07-30 16:18 ` Jassi Brar
2018-07-30 16:49 ` Oleksij Rempel
2018-07-31 2:51 ` Jassi Brar
2018-07-31 7:21 ` A.s. Dong
2018-07-31 10:15 ` Jassi Brar
2018-07-31 12:42 ` Jassi Brar
2018-08-02 9:24 ` A.s. Dong
2018-08-09 2:22 ` A.s. Dong
2018-08-09 2:55 ` Jassi Brar
2018-08-09 6:45 ` A.s. Dong
2018-07-30 8:29 ` A.s. Dong
2018-07-30 8:39 ` A.s. Dong
2018-07-26 6:53 ` [PATCH v7 4/6] dt-bindings: mailbox: imx-mu: add i.MX6SX and i.MX7S SoCs Oleksij Rempel
2018-07-26 8:16 ` A.s. Dong
2018-07-26 9:55 ` Jassi Brar
2018-07-26 10:41 ` Lucas Stach
2018-07-26 11:15 ` Jassi Brar
2018-07-26 11:35 ` Lucas Stach
2018-07-26 11:46 ` Jassi Brar
2018-07-26 11:51 ` Vladimir Zapolskiy
2018-07-26 12:00 ` Jassi Brar
2018-07-26 12:10 ` Vladimir Zapolskiy
2018-07-26 11:54 ` Lucas Stach
2018-07-26 11:44 ` Vladimir Zapolskiy
2018-07-26 11:52 ` Jassi Brar
2018-07-26 11:55 ` Vladimir Zapolskiy
2018-07-26 12:10 ` Jassi Brar
[not found] ` <CABb+yY02KNB9ELKiWYdB0LyvTghhk+nk-dTUGfG8_+KUB_H=Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-26 12:41 ` Vladimir Zapolskiy
2018-07-30 22:22 ` Rob Herring
2018-07-31 10:16 ` Jassi Brar
2018-07-31 10:18 ` Jassi Brar
2018-07-26 6:53 ` [PATCH v7 5/6] ARM: dts: imx7s: add i.MX7 messaging unit support Oleksij Rempel
2018-07-26 8:11 ` Lucas Stach
2018-07-26 6:53 ` [PATCH v7 6/6] mailbox: Add support for i.MX7D messaging unit Oleksij Rempel
2018-07-26 8:07 ` Lucas Stach
2018-07-26 10:15 ` Jassi Brar
2018-07-26 10:51 ` Oleksij Rempel
2018-07-26 11:09 ` Jassi Brar [this message]
2018-07-26 11:42 ` Oleksij Rempel
2018-07-26 12:17 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABb+yY2=mFr+gFuWyE+VyG6dWj3gKhTs6X+U9UjFu5N=4zU5uA@mail.gmail.com' \
--to=jassisinghbrar@gmail.com \
--cc=", linux-arm-kernel"@lists.infradead.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).