From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinath Mannam Subject: Re: [PATCH v5 0/3] Stingray thermal driver support Date: Wed, 5 Dec 2018 08:47:52 +0530 Message-ID: References: <1539702680-3746-1-git-send-email-srinath.mannam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Florian Fainelli Cc: Daniel Lezcano , Zhang Rui , Eduardo Valentin , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , BCM Kernel Feedback List-Id: devicetree@vger.kernel.org Hi, Could you please provide your feedback to this patch series? Regards, Srinath. On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli wrote: > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > These patches adds the stingray thermal driver and its > > corresponding DT nodes with documentation. > > Can we get feedback from the thermal maintains whether this is > acceptable or not? > > > > > Changes from v4 > > - Addressed Rob Herring comments on DT parameters and > > thermal driver architecture. > > - Removed brcm,max-crit-temp DT parameter > > - Changed driver to thermal sensor registration model. > > - Added trip DT properties. > > > > Changes from v3 > > - Addressed Daniel lezcano comments. > > - Elaborated commit description of thermal driver patch. > > - Added brcm,max-crit-temp DT parameter. > > > > Changes from v2: > > - All stingray TMON DT nodes are combine together into single. > > Temperature registers are combined into one mem resource. > > brcm,tmon-mask parameter has available TMONs mask value. > > - All available TMONs are initialized together in single > > instance of driver probe call. > > > > Changes from v1: > > - Fixed auto build sparce warning. > > > > Pramod Kumar (3): > > dt-bindings: thermal: Add binding document for SR thermal > > thermal: broadcom: Add Stingray thermal driver > > arm64: dts: stingray: Add Stingray Thermal DT support. > > > > .../bindings/thermal/brcm,sr-thermal.txt | 105 ++++++++++++++++ > > .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 89 +++++++++++++ > > drivers/thermal/Kconfig | 3 +- > > drivers/thermal/broadcom/Kconfig | 9 ++ > > drivers/thermal/broadcom/Makefile | 1 + > > drivers/thermal/broadcom/sr-thermal.c | 138 +++++++++++++++++++++ > > 6 files changed, 344 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt > > create mode 100644 drivers/thermal/broadcom/sr-thermal.c > > > > -- > Florian