From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Perier Subject: Re: [PATCH 2/2] ARM: dts: meson: Adding hwrev syscon node Date: Thu, 18 Feb 2016 13:33:04 +0100 Message-ID: References: <1455730114-2547-1-git-send-email-romain.perier@gmail.com> <1455730114-2547-3-git-send-email-romain.perier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Carlo Caione Cc: linux-meson-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel , Carlo Caione , devicetree List-Id: devicetree@vger.kernel.org Hi, 2016-02-17 21:36 GMT+01:00 Carlo Caione : > On Wed, Feb 17, 2016 at 6:28 PM, Romain Perier wrote: >> These are the CBUS registers used to retrieve the revision and the >> identifier of the SoC on Meson8. >> >> Signed-off-by: Romain Perier >> --- >> arch/arm/boot/dts/meson8b.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi >> index 0477a81..71009dc 100644 >> --- a/arch/arm/boot/dts/meson8b.dtsi >> +++ b/arch/arm/boot/dts/meson8b.dtsi >> @@ -99,6 +99,11 @@ >> }; >> }; >> >> + hwrev@c1107d4c { >> + compatible = "amlogic,meson8b-hwrev", "syscon"; >> + reg = <0xc1107d4c 0x460>; > > Interesting. Where did you get 0x460? Carlo, Arnd. Well, what I did is the following : - CBUS_PHY_BASE is 0xc1100000 (CBUS is a larger block of registers, like slcr on zynq) - the serial is at CBUS_PHY_BASE + 0x7d4c - the revision is at CBUS_PHY_BASE + 0x81a8 So I decided to create a device_node for hw revision at 0xc1107d4c, in this case the lenght is 0x460... Am I wrong ? > >> + }; >> + >> sram: sram@d9000000 { >> compatible = "mmio-sram"; >> reg = <0xd9000000 0x20000>; > > This patch fails to apply on the current master. Probably because you > have based this patch on a repo containing (as I can see) also my WiP > patches on SMP. I used linux-next with your patches on top of it yes... I will rebase it Thanks, Romain -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html