From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Perier Subject: Re: [PATCH v5 1/2] of: Rename "poweroff-source" property to "system-power-controller" Date: Tue, 25 Nov 2014 16:57:56 +0100 Message-ID: References: <1416918506-9366-1-git-send-email-romain.perier@gmail.com> <1416918506-9366-2-git-send-email-romain.perier@gmail.com> <20141125144007.9904BC44343@trevor.secretlab.ca> <20141125145410.GD19910@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20141125145410.GD19910@localhost> Sender: linux-pm-owner@vger.kernel.org To: Johan Hovold Cc: Grant Likely , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Lee Jones , Mark Brown , robh , devicetree , Liam Girdwood , Mark Rutland , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Felipe Balbi List-Id: devicetree@vger.kernel.org Thanks for your feedbacks. I think that Mark will probably wait until there are more reviews on this serie. (this is exactly what he asked for the previous one) 2014-11-25 15:54 GMT+01:00 Johan Hovold : > On Tue, Nov 25, 2014 at 02:40:07PM +0000, Grant Likely wrote: >> On Tue, 25 Nov 2014 12:28:25 +0000 >> , Romain Perier >> wrote: >> > It reverts commit a4b4e0461ec5 ("of: Add standard property for poweroff capability"). >> > As discussed on the mailing list, it makes more sense to rename back to the >> > old established property name, without the vendor prefix. Problem being that >> > the word "source" usually tends to be used for inputs and that is out of control >> > of the OS. The poweroff capability is an output which simply turns the >> > system-power off. Also, this property might be used by drivers which power-off >> > the system and power back on subsequent RTC alarms. This seems to suggest to >> > remove "poweroff" from the property name and to choose "system-power-controller" >> > as the more generic name. This patchs adds the required renaming changes and >> > defines an helper function which checks if this property is set. >> > >> > Signed-off-by: Romain Perier >> >> For both patches: >> Acked-by: Grant Likely >> >> Let me know if I need to take this series through my tree. Also, does it >> need to go into v3.18 and be backported to stable? Or just v3.19. > > It's only needed in the regulator tree for 3.19, and does not need to be > backported. > > We could convert the drivers (and dts) that currently use > ",system-power-controller" to use the new helper (while > maintaining backward compatibility) after 3.19-rc1 is out. > > Johan