devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrien Grassein <adrien.grassein@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: DTML <devicetree@vger.kernel.org>,
	will@kernel.org, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	bjorn.andersson@linaro.org, Rob Herring <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	catalin.marinas@arm.com, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support
Date: Tue, 30 Mar 2021 10:54:47 +0200	[thread overview]
Message-ID: <CABkfQAE_RkqGW5f6TkPJVGNZKOWVRr5LLTeRvWQuJ4riiR+SVw@mail.gmail.com> (raw)
In-Reply-To: <0d173681-7eb6-798f-7d9b-66a221625d34@pengutronix.de>

Hello Ahmad,

Le mar. 30 mars 2021 à 10:38, Ahmad Fatoum <a.fatoum@pengutronix.de> a écrit :
>
> Hello Adrien,
>
> On 30.03.21 10:35, Adrien Grassein wrote:
> > Add the description for the USB host port.
> > At this time, the port will not work directly from the
> > kernel because it's connected through a resettable hub
> > that is not handle in the kernel. It should be controlled
> > in the bootloader or in the userspace.
>
> Couldn't you add a gpio-hog that gets the hub out of reset?
>

Let's try, I didn't think about this solution ^^.

> Cheers,
> Ahmad
>
> >
> > In the case of the Boundary's u-boot, this is done on the
> > boot script:
> > "
> > starting USB...
> > Bus usb@38100000: Register 2000140 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.10
> > Bus usb@38200000: Register 2000140 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.10
> > scanning bus usb@38100000 for devices... 1 USB Device(s) found
> > scanning bus usb@38200000 for devices... 3 USB Device(s) found
> > "
> >
> > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > ---
> >  .../boot/dts/freescale/imx8mq-nitrogen.dts    | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > index b46f45a82be1..7a52e247c527 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts
> > @@ -213,6 +213,22 @@ &usb3_phy0 {
> >       status = "okay";
> >  };
> >
> > +&usb_dwc3_1 {
> > +     dr_mode = "host";
> > +     status = "okay";
> > +};
> > +
> > +/*
> > + * On this board, USB host is connected to a resettable hub.
> > + * The reset signal is connected to the GPIO <&gpio1 14 GPIO_ACTIVE_LOW>.
> > + * You need to activate it in the bootloader or in the userspace.
> > + */
> > +&usb3_phy1 {
> > +     status = "okay";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_usb3_1>;
> > +};
> > +
> >  &usdhc1 {
> >       assigned-clocks = <&clk IMX8MQ_CLK_USDHC1>;
> >       assigned-clock-rates = <400000000>;
> > @@ -388,6 +404,12 @@ MX8MQ_IOMUXC_GPIO1_IO13_USB1_OTG_OC              0x16
> >               >;
> >       };
> >
> > +     pinctrl_usb3_1: usb3-1grp {
> > +             fsl,pins = <
> > +                     MX8MQ_IOMUXC_GPIO1_IO14_GPIO1_IO14              0x16
> > +             >;
> > +     };
> > +
> >       pinctrl_usdhc1: usdhc1grp {
> >               fsl,pins = <
> >                       MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK                 0x83
> >
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Thanks,
Adrien

  reply	other threads:[~2021-03-30  8:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  8:35 [PATCH v1 0/4] Add peripheral support to imx8mq-nitrogen board Adrien Grassein
2021-03-30  8:35 ` [PATCH v1 1/4] arm64: dts: imx8mq-nitrogen: add USB OTG support Adrien Grassein
2021-03-30  8:35 ` [PATCH v1 2/4] arm64: dts: imx8mq-nitrogen: add USB HOST support Adrien Grassein
2021-03-30  8:38   ` Ahmad Fatoum
2021-03-30  8:54     ` Adrien Grassein [this message]
2021-03-30  8:35 ` [PATCH v1 3/4] arm64: dts: imx8mq-nitrogen: add lt8912 MIPI-DSI to HDMI Adrien Grassein
2021-03-30  8:35 ` [PATCH v1 4/4] arm64: defconfig: Enable LT8912B DRM bridge driver Adrien Grassein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABkfQAE_RkqGW5f6TkPJVGNZKOWVRr5LLTeRvWQuJ4riiR+SVw@mail.gmail.com \
    --to=adrien.grassein@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).