devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrien Grassein <adrien.grassein@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mmc: add an option to disable HS400 for fsl
Date: Fri, 4 Dec 2020 21:06:09 +0100	[thread overview]
Message-ID: <CABkfQAEnVqOikmEBy2XhzSUM1zzvTSLJvMEP8M_k_EfpRuDw5w@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFp0U5=s_AJh4-QAn=WCodkYUaFE9BuLjpJB80z23J7JkA@mail.gmail.com>

Hello,

Thanks, it's working with your suggestion.

You can delete/abandon these patches.

Thanks a lot,
Regards,
Adrien

Le ven. 4 déc. 2020 à 14:18, Ulf Hansson <ulf.hansson@linaro.org> a écrit :
>
> On Sun, 29 Nov 2020 at 21:31, Adrien Grassein <adrien.grassein@gmail.com> wrote:
> >
> > Add an option to disable the hs400 support in the fsl esdhc
> > driver.
> >
> > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > index e71d13c2d109..070b40ae8c44 100644
> > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > @@ -101,6 +101,10 @@ properties:
> >        If not use this property, driver default set the delay target to value 7.
> >        Only eMMC HS400 mode need to take care of this property.
> >      default: 0
> > +  fsl,no-mmc-hs400:
> > +    description: |
> > +      boolean, if present, indicate to disable mmc-hs400 support.
> > +    type: boolean
>
> You need to disable hs400, because the sdhci capability register
> wrongly claims it to be supported, right?
>
> May I suggest using the DT property "sdhci-caps-mask" instead?
>
> Kind regards
> Uffe

      reply	other threads:[~2020-12-04 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 20:31 [PATCH 1/2] dt-bindings: mmc: add an option to disable HS400 for fsl Adrien Grassein
2020-11-29 20:31 ` [PATCH 2/2] mmc: sdhci-esdhc-imx: allow to disable HS400 support Adrien Grassein
2020-12-04 13:18 ` [PATCH 1/2] dt-bindings: mmc: add an option to disable HS400 for fsl Ulf Hansson
2020-12-04 20:06   ` Adrien Grassein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABkfQAEnVqOikmEBy2XhzSUM1zzvTSLJvMEP8M_k_EfpRuDw5w@mail.gmail.com \
    --to=adrien.grassein@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).