From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A651206968 for ; Wed, 16 Oct 2024 10:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729074032; cv=none; b=pbvb8VAOERkBqiDI/EI4T15ED9mQ1G/INfmDBnoYy7hnW9j506jXCIh2yHpHFgV9kx4hYGpTlqkFVDIsLIY955cB4PJMEYA/M2B7d/VACUi2znMnChwtD579Ai36+LwxfX+Xfhij7DB+EFNt58iiplhtgQk4WaolhACnHDQLYBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729074032; c=relaxed/simple; bh=JprLKTC6HJjybS1n1cL4X9uzLlKWlrTcyJd8jH5iYLw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=GDaHK2aDBmNEdcPpAdQ5eTBBqamR1hShJEZEO04DOCdiPTXLH0fa66YxU0TPY/b+7oJ/ZVh2JoTQfDrQW6uI1d5XACE29cB9UUCDkDO0rTQJCtX9cWLwmrutbCIX0K7IxDg0hjLiyuALGrdlbb9bx83x0czstGhKJ5O29jfZJ+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=VUninvBx; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="VUninvBx" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7ea8ecacf16so1790946a12.1 for ; Wed, 16 Oct 2024 03:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1729074030; x=1729678830; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eu9n9kTYZMIYrnQIr/xJejQUar2J34x4A7S5/oQVpRg=; b=VUninvBxgYCjAkAm62Gl1Xvwq3IXqkKp/UQQu9PgF3djl83vKohArpt6XgRiJROTyb XV9fdvaujli8oZZHRKnlxN8zad/RMVs2V0OyulDXbjvwyj9TREP+rIkNaTUnEo8Wssc/ mDq5sRWcjgJLDYP+3QrTEBXxQJvLzHqHKGMHYCRdFs4IxZETBh/J7l+Kio0wdFlhoyfo j8nSJsdlFzsdp1hb/RFPEeUe0CzSLPLwM4/Y7eBvDEbmPbAZirfNhXSys2YaO166Gd3e xKx/2l/G06ESiFDeoGcK5J5r30e8CR/GRbiWv9K2lERt4ZwoClarztoPrXNEAXGKLdZ+ EpLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729074030; x=1729678830; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eu9n9kTYZMIYrnQIr/xJejQUar2J34x4A7S5/oQVpRg=; b=kyOp47ZG2cfcb6mur4bB9m6q1uPZv/xwz/dcHRimASccvP9X5/qHZsjDuBpWiVN6J8 kceK5BSsjZfdl6pf4T15An0quTxd+4gLikbDfzU14Ik3HZusgUm+CaM+3GED8B8jNwkj /ZJa4tk88tCSe+lB+14FBbiINM71iDZbV5Nv44UmXYSDSrd6X5YWaiSabzvAKptTrzun bcoE9Q1ksnI4/kqsamB7sL5RxwoAGcx0VGZhuDA0pRrq3gOHs7qoYVKEOyvPGQM58UKb +t2I/6SW5NVh3P8Alfz0PFqjdLCGMPsTCUWrEHvJ+7308l6z2PY3f68K3ZsA19h4kxWE ICLg== X-Forwarded-Encrypted: i=1; AJvYcCVkuEnYcpurBEyFLpFL7duDURiIo+jYHu26OOAolFHhzOFCGMTdWDwwKWTfKJGu7aZnt6n6uhhtArYg@vger.kernel.org X-Gm-Message-State: AOJu0YziQT5kZjjM+EpfedFIG7n3QZEOYK4JZXhxWwbblSwi8RkG59pD PjGlGIxyNhSbN4dV3ZktF+S6cN5CtWooC4wcRyugG5R2CHtWzp5WnmzFcZTVNfs3Xt7/nJX67wu iAp8fEKQXN0YHG1+t2GCg0lD06AxXpWa/+i9Szw== X-Google-Smtp-Source: AGHT+IH0NF5PxQ3frSjJAxZyupIfoZEdqDvzpH+HOYXoFDZ6HVhysB/row6aeG7r9j1NrxBIXdKi1U2gHx81js9QOnY= X-Received: by 2002:a05:6a21:1706:b0:1d8:f048:c0e4 with SMTP id adf61e73a8af0-1d8f048c30cmr8138462637.36.1729074030317; Wed, 16 Oct 2024 03:20:30 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241015113329.667831-1-naresh.solanki@9elements.com> <20241015113329.667831-2-naresh.solanki@9elements.com> In-Reply-To: From: Naresh Solanki Date: Wed, 16 Oct 2024 15:50:20 +0530 Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings To: Krzysztof Kozlowski Cc: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sylvester Bauer , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, On Tue, 15 Oct 2024 at 17:18, Krzysztof Kozlowski wrote: > > On 15/10/2024 13:33, Naresh Solanki wrote: > > Add bindings for Vicor pli1209bc. > > It a Digital Supervisor with Isolation for use with BCM Bus Converter > > Modules. > > > > Signed-off-by: Naresh Solanki > > --- > > .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++ > > This has to be squashed with previous patch. > > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml > > new file mode 100644 > > index 000000000000..3647d14e9111 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > Drop blank line Ack > > > +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,pli1209bc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Vicor PLI1209BC Power Regulator > > + > > +maintainers: > > + - Marcello Sylvester Bauer > > + - Naresh Solanki > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. Ack > > > + The Vicor PLI1209BC is a Digital Supervisor with Isolation for use > > + with BCM Bus Converter Modules. > > + > > +properties: > > + compatible: > > + enum: > > + - vicor,pli1209bc > > + > > + reg: > > + maxItems: 1 > > + > > + regulators: > > Drop the node and define vout2 here directly.... unless anything needs > such layout? Then explain this in commit msg. This is expected by pmbus regulator driver: https://github.com/torvalds/linux/blob/master/drivers/hwmon/pmbus/pmbus.h#L512 > > > + type: object > > + description: > > + List of regulators provided by this controller. > > + > > + properties: > > + vout2: > > + $ref: /schemas/regulator/regulator.yaml# > > + type: object > > + > > Drop blank line. Ack > > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > Drop, not used. Ack > > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pli1209bc_p12v_d: regulator@5f { > > Drop unused prefix Ack Regards, Naresh > > > + compatible = "vicor,pli1209bc"; > > + reg = <0x5f>; > > + > > + regulators { > > + p12v_d: vout2 { > > + regulator-name = "bcm3"; > > + regulator-boot-on; > > + }; > > + }; > > + }; > > + }; > > + > > Best regards, > Krzysztof >