From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 15/26] ARM: omap4-panda.dts: add display information Date: Mon, 9 Dec 2013 16:09:09 +0100 Message-ID: References: <1386160133-24026-1-git-send-email-tomi.valkeinen@ti.com> <1386160133-24026-16-git-send-email-tomi.valkeinen@ti.com> <52A5BDF4.2070304@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <52A5BDF4.2070304@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Tomi Valkeinen Cc: "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren , Enric Balletbo Serra List-Id: devicetree@vger.kernel.org Hi Tomi, On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen wrote: > On 2013-12-06 10:57, Javier Martinez Canillas wrote: > >>> + tfp410: encoder@0 { >>> + compatible = "ti,tfp410"; >>> + gpios = <&gpio1 0 0>; /* 0, power-down */ >>> + >> >> Please use the constants from include/dt-bindings/ instead of magic >> numbers, i.e: >> >> gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ > > Thanks, fixed now (for all .dts files) > > However... The TFP410 gpio is "power-down". I think we should actually > mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. > yes, I looked at the TFP410 datasheet [0] and the Power Down pin is indeed an active-low, I just replaced to GPIO_ACTIVE_HIGH since you were using a constant 0 and include/dt-bindings/gpio/gpio.h defines GPIO_ACTIVE_HIGH as 0. I just asked to Enric why we use GPIO_ACTIVE_HIGH for the PD pin on the IGEPv2 DTS instad and is because the IGEP board uses a hardware signal inverter but that is a special case. I don't know about the Panda board since I haven't looked at its datasheet. Thanks a lot and best regards, Javier [0]: http://www.ti.com/lit/ds/slds145b/slds145b.pdf