From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 4/4] ARM: DTS: Add NTC thermistor nodes as child nodes to ADC Date: Wed, 25 Jun 2014 09:37:14 +0200 Message-ID: References: <1403612356-23685-1-git-send-email-ch.naveen@samsung.com> <1403612356-23685-5-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Naveen Krishna Ch Cc: Doug Anderson , Naveen Krishna Chatradhi , linux-samsung-soc , linux-iio , Kukjin Kim , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "cpgs ." , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Lars-Peter Clausen , Tushar Behera List-Id: devicetree@vger.kernel.org Hello Naveen, On Wed, Jun 25, 2014 at 7:04 AM, Naveen Krishna Ch wrote: > Doug, > > On 25 June 2014 03:24, Doug Anderson wrote: >> Naveen, >> >> On Tue, Jun 24, 2014 at 5:19 AM, Naveen Krishna Chatradhi >> wrote: >>> Exynos5420 based Peach PIT and Exynos5800 based PI boards have >>> 4 NTC thermistors to measure temperatures at various points on the >>> board. >>> >>> IIO based ADC becomes the parent and NTC thermistors are the childs, >>> via the HWMON interface. >>> >>> Signed-off-by: Naveen Krishna Chatradhi >>> Cc: Doug Anderson >>> --- >>> This patch needs >>> 1. MAX77802 PMIC device tree nodes (for ldo9) >>> https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html >>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix >>> >>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 32 ++++++++++++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >> >> * You forgot: status="okay" for the ADC. One might question how this >> patch was tested. > > Will correct it. > >> >> * Please also include this change for pi. > > MAX77802 device node was not added for Peach_PI (exynos5800-peach-pi.dts). > I guess, Javier have a plan to send. > That's correct. I didn't include the changes to Peach Pi since I only have a Pit to test but I'll add it on the next version so you can have that patch as a dependency and use the MAX77802 LD9 regulator. > I will edit the commit message to remove Peach_PI for now. > > Also, we have few similar nodes on Peach PI and Peach PIT. > Any plans or discussion on merging the common nodes ? > >> >> * We just got through the painful process of sorting this .dts file. >> Please sort "&adc" alphabetically. Kukjin: please confirm that you >> will keep an eye on patches and make sure that they are sorted OK. >> >> >> Other than those problems this seems to work fine to me. >> >> -Doug > > Thanks for the Review. > > > -- > Shine bright, > (: Nav :) Best regards, Javier