From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60332C61DA4 for ; Fri, 3 Feb 2023 03:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbjBCDpi (ORCPT ); Thu, 2 Feb 2023 22:45:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231629AbjBCDpg (ORCPT ); Thu, 2 Feb 2023 22:45:36 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5BB6721F8 for ; Thu, 2 Feb 2023 19:45:35 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id v17so6041171lfd.7 for ; Thu, 02 Feb 2023 19:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8zrhD271lrTttGluQF+PCnQmCDKl2CENWlcyeC9oezU=; b=EnvtQcOYczYc3Hm8HN1M+u5/bCD8+AZQuZx40gf9LLFJRhaayJZiN7xh9oQ0HbVyv5 WlaBYyooZpDvygERB3VBtzkrYmMoRceclFbdlBAjpw6s3BrzcsR9GMuvvHXM2bDqDLx5 fiEDoomZEKpQ2lVHcskZkAyOV/HWXozdlOInzcSzGZpCsnZTNVqMgP1U7axh1r7D1ybs N84+JtK8ZIBIGRZSjODPD49Lj0tHIfDl6PCMPbnteNEbCC2uBDrVFrMNxX1u6RcOeMJt 4WxLC+55i29BnBlZlD4M/NOLRiFx0LCmRdEqYBB6SB+jV2NwBiuXG3x496+i+NVQrFB5 ukNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8zrhD271lrTttGluQF+PCnQmCDKl2CENWlcyeC9oezU=; b=L+3tQ+My7DjFT6vHEYygv5OLE2ktWfPduDFnY5SanoQuP/2nM8EC+KGIsmq+ZWoyVY 2PWYRFE9RcLfbMY1AHrgPcDXBr844tQ/IdaY1yOV40WkyKIVUivRJewH0ZmEplGk4In9 ZJ7GYxNXOzQTqZ+jqW63YnRyluMBjO9wanAMvTZ2214ndvDrduKdIhiflABFxNZZz2jm C72saBMDvkkckFRzGGmFYnHQZKLA5MURxmSQaJFAQbXpdPjdIMljJd400FWMmheBi/78 +5BXr5q14sTpjE8GLDNysLSEa4lXYsHA7r8lt54vDKBBqRO51YES5NOPTMGvPTUfb5pG w28Q== X-Gm-Message-State: AO0yUKWfD5kMMlm/jB5/D5MQ+1KZqGakp68LgntJ0tv/BrMsX9PXzlJj tj8P9bsH9NReucgWg3/Dt20eGmboS0kuLCXz/F6e+g== X-Google-Smtp-Source: AK7set9mvhjgLBscCSmB7QGxYq4dFW8q88IFngk26C54TKNXnncufj9MdP1Re09yaxaXAyMUSRPNPzBfHdP7B3ZfrTs= X-Received: by 2002:a05:6512:3d28:b0:4d8:8ad1:a05c with SMTP id d40-20020a0565123d2800b004d88ad1a05cmr1245389lfv.140.1675395933982; Thu, 02 Feb 2023 19:45:33 -0800 (PST) MIME-Version: 1.0 References: <20230201080227.473547-1-jun.nie@linaro.org> <9ab7383b-f3ed-3e48-d275-3c8933be5f2f@kernel.org> <957f2bd0-d249-169b-04cc-242b9fcf8c6b@kernel.org> In-Reply-To: <957f2bd0-d249-169b-04cc-242b9fcf8c6b@kernel.org> From: Jun Nie Date: Fri, 3 Feb 2023 11:45:31 +0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings To: Krzysztof Kozlowski Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, bryan.odonoghue@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Krzysztof Kozlowski =E4=BA=8E2023=E5=B9=B42=E6=9C=882=E6= =97=A5=E5=91=A8=E5=9B=9B 17:42=E5=86=99=E9=81=93=EF=BC=9A > > On 02/02/2023 10:29, Jun Nie wrote: > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - qcom,msm8939-cci > >>> + > >>> + clocks: > >>> + maxItems: 1 > >>> + > >>> + operating-points-v2: true > >>> + opp-table: > >>> + type: object > >>> + > >>> +required: > >>> + - compatible > >>> + - clocks > >>> + - operating-points-v2 > >>> + - nvmem-cells > >> > >> ?? You cannot require properties which are not present. > >> > >>> + - power-domains > >> > >> Same here. > >> > > > > So the properties should be added later, after cpr and fuse nodes are > > available in mainline, right? > > No, binding should be complete, so why would you skip some properties? I > don't see here dependency on other bindings. Unless I missed here > something and there is a dependency? But then what kind? Do you > reference other schema? > > Best regards, > Krzysztof > Sorry, it is a copy/modified error with overlooking some added properties. + cci_opp3: opp-cpr14-400000000 { + opp-hz =3D /bits/ 64 <400000000>; + opp-supported-hw =3D <0x1>; + required-opps =3D <&cpr_opp14>; + }; + + cci_opp4: opp-cpr15-400000000 { Documentation/devicetree/bindings/interconnect/qcom,cci.example.dtb: opp-table-cci: Unevaluated properties are not allowed ('opp-cpr14-400000000', 'opp-cpr15-400000000' were unexpected) Do you know how to fix this dts check warning? The cci_opp3 and cci_opp4 have the same frequency but with different requirements to power domain. So the name of the 2 opp should be identical or with a different tag, but there are warnings for both cases for the 2 lines. Thanks! + opp-hz =3D /bits/ 64 <400000000>; + opp-supported-hw =3D <0x3e>; + required-opps =3D <&cpr_opp15>; + };