From: Jun Nie <jun.nie@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, bryan.odonoghue@linaro.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver
Date: Wed, 1 Feb 2023 23:23:31 +0800 [thread overview]
Message-ID: <CABymUCPiOFH_FM45bYt=zgFSP37xtVkLUW_mtAOp9SbdT05itA@mail.gmail.com> (raw)
In-Reply-To: <515f4e9e-2804-e03a-26f5-f2d3ac331109@linaro.org>
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> 于2023年2月1日周三 19:32写道:
>
> On 01/02/2023 10:02, Jun Nie wrote:
> > Cache Coherent Interconnect (CCI) is used by some Qualcomm SoCs. This
> > driver is introduced so that its freqency can be adjusted. And regulator
> > associated with opp table can be also adjusted accordingly which is
> > shared with cpu cluster.
> >
> > Signed-off-by: Jun Nie <jun.nie@linaro.org>
> > ---
> > drivers/devfreq/Kconfig | 9 +++
> > drivers/devfreq/Makefile | 1 +
> > drivers/devfreq/qcom-cci.c | 162 +++++++++++++++++++++++++++++++++++++
> > 3 files changed, 172 insertions(+)
> > create mode 100644 drivers/devfreq/qcom-cci.c
>
> Could you please describe in some additional details what are you trying
> to achieve? Should the CCI frequency be scaled manually or does it
> follow the cluster frequency? Do clusters vote on the CCI frequency?
>
> I'm inclined to ask if it is possible to shift this to the cpufreq OPP
> tables?
>
> --
> With best wishes
> Dmitry
>
The plan is to add CCI opp node as required-opp property in CPU opp, so that
CPU will vote CCI frequency when scaling CPU frequency.
The interconnect bandwidth side is not addressed yet. This patch only address
CCI frequency and power voltage requirement with help of device tree.
- Jun
next prev parent reply other threads:[~2023-02-01 15:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 8:02 [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Jun Nie
2023-02-01 8:02 ` [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver Jun Nie
2023-02-01 8:48 ` Krzysztof Kozlowski
2023-02-01 15:15 ` Jun Nie
2023-02-01 10:27 ` Bryan O'Donoghue
2023-02-01 11:02 ` Chanwoo Choi
2023-02-01 15:17 ` Jun Nie
2023-02-01 17:18 ` Dmitry Baryshkov
2023-02-01 11:32 ` Dmitry Baryshkov
2023-02-01 11:46 ` Bryan O'Donoghue
2023-02-01 13:41 ` Dmitry Baryshkov
2023-02-01 14:45 ` Bryan O'Donoghue
2023-02-01 14:58 ` Dmitry Baryshkov
2023-02-01 15:17 ` Bryan O'Donoghue
2023-02-01 17:12 ` Dmitry Baryshkov
2023-02-01 17:16 ` Bryan O'Donoghue
2023-02-01 17:19 ` Dmitry Baryshkov
2023-02-02 12:55 ` Jun Nie
2023-02-01 15:23 ` Jun Nie [this message]
2023-02-01 8:43 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm CCI dt-bindings Krzysztof Kozlowski
2023-02-02 9:29 ` Jun Nie
2023-02-02 9:42 ` Krzysztof Kozlowski
2023-02-03 3:45 ` Jun Nie
2023-02-03 7:06 ` Krzysztof Kozlowski
2023-02-01 10:46 ` Chanwoo Choi
2023-02-01 14:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABymUCPiOFH_FM45bYt=zgFSP37xtVkLUW_mtAOp9SbdT05itA@mail.gmail.com' \
--to=jun.nie@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).