From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4F8C05027 for ; Wed, 1 Feb 2023 15:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbjBAPYP (ORCPT ); Wed, 1 Feb 2023 10:24:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbjBAPYH (ORCPT ); Wed, 1 Feb 2023 10:24:07 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F827375B for ; Wed, 1 Feb 2023 07:23:41 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id bi36so491776lfb.8 for ; Wed, 01 Feb 2023 07:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MoSqvQg1GJaKeyTfybVMaXngI5eDO0jVwAafYr5hVKU=; b=szZvNlMUdkP3w6JCsAuE79LB9wtOWg1++ZCq9iPKy7zka1EVmjEW3qqucNVH4T0hIZ P/iuNKWCU4tA9zIB++SviZhwWj707/txtO6ZnAZRKEcb2uB/mn6faxssRINs1Y3Zew7Q mPzQ7bPomVia69ZW5GlWu7yNk3/CyJ7d/EiySErugA+xYkHJHANOfoSKMqOFvZVP+Scx AUV1LcrKq1nQzs5lw2wavLulYJBvMqr0vzc/+MAl3JS/CUmN/GDbwfC6g8pJlJFUOv8k FGjixJ6rMQQ1i1Pw8brm6e+MrdaEfgdeqRE179snCFcC2+PiEhDWBo7+7rO7M9AYf4aN DvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MoSqvQg1GJaKeyTfybVMaXngI5eDO0jVwAafYr5hVKU=; b=XIGJnN4YK+IiIy7IeKcJBcS7mnaCjon4p5fyk3Vs4zFShKaeVrvfPbLV1I4GPOIepm 9jL3CSVE3AY705Br6L16rstkhGVKqG2PnChd2xLqS6EbxgiYgmGyXezC3O0uCgRc7sd1 YfXAByht/CuUwbYIleaDb9Crjhqsoq4bA8oSJtPPIB5fIGMFmuvglLgzkXKjQAFNQ4Vv UvRjtITjn5e1sWqEAcZrOM0mpD9IsZdM0CTuva+Artpo5QKKNJ480HJ/POPh166cvzzP Ivg9HhFa8QW28sFUMOHrjxpzTm05PtGq2DOskbSq8gUlNYqyiAVcZTZTdCk+sIqzjykO NvHQ== X-Gm-Message-State: AO0yUKUCy0agYC6Gk295N+5J+bwSL1HIPtJ37oSWvfP88iNaZwBOfKYJ 0QPkN+5btoGWbCmiv4+LQMokfLit1RyBJwnvv60yCw== X-Google-Smtp-Source: AK7set8lD9RYwj5y3uPcFqci2GlPGZco2Qa5+WkHYRX4QzH3uKwz4E7Ay87dbJ4C6gpk1uhkVlIojtB/fQ/EflImrb4= X-Received: by 2002:a05:6512:ba3:b0:4ca:f5a1:8898 with SMTP id b35-20020a0565120ba300b004caf5a18898mr331079lfv.29.1675265015202; Wed, 01 Feb 2023 07:23:35 -0800 (PST) MIME-Version: 1.0 References: <20230201080227.473547-1-jun.nie@linaro.org> <20230201080227.473547-2-jun.nie@linaro.org> <515f4e9e-2804-e03a-26f5-f2d3ac331109@linaro.org> In-Reply-To: <515f4e9e-2804-e03a-26f5-f2d3ac331109@linaro.org> From: Jun Nie Date: Wed, 1 Feb 2023 23:23:31 +0800 Message-ID: Subject: Re: [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver To: Dmitry Baryshkov Cc: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, bryan.odonoghue@linaro.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Dmitry Baryshkov =E4=BA=8E2023=E5=B9=B42=E6= =9C=881=E6=97=A5=E5=91=A8=E4=B8=89 19:32=E5=86=99=E9=81=93=EF=BC=9A > > On 01/02/2023 10:02, Jun Nie wrote: > > Cache Coherent Interconnect (CCI) is used by some Qualcomm SoCs. This > > driver is introduced so that its freqency can be adjusted. And regulato= r > > associated with opp table can be also adjusted accordingly which is > > shared with cpu cluster. > > > > Signed-off-by: Jun Nie > > --- > > drivers/devfreq/Kconfig | 9 +++ > > drivers/devfreq/Makefile | 1 + > > drivers/devfreq/qcom-cci.c | 162 ++++++++++++++++++++++++++++++++++++= + > > 3 files changed, 172 insertions(+) > > create mode 100644 drivers/devfreq/qcom-cci.c > > Could you please describe in some additional details what are you trying > to achieve? Should the CCI frequency be scaled manually or does it > follow the cluster frequency? Do clusters vote on the CCI frequency? > > I'm inclined to ask if it is possible to shift this to the cpufreq OPP > tables? > > -- > With best wishes > Dmitry > The plan is to add CCI opp node as required-opp property in CPU opp, so tha= t CPU will vote CCI frequency when scaling CPU frequency. The interconnect bandwidth side is not addressed yet. This patch only addre= ss CCI frequency and power voltage requirement with help of device tree. - Jun