From: Tyrone Ting <warp5tw@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: semen.protsenko@linaro.org, andriy.shevchenko@linux.intel.com,
yuenn@google.com, digetx@gmail.com, devicetree@vger.kernel.org,
tmaimon77@gmail.com, krzysztof.kozlowski@canonical.com,
lukas.bulwahn@gmail.com, Avi.Fishman@nuvoton.com,
JJLIU0@nuvoton.com, tali.perry1@gmail.com, jie.deng@intel.com,
openbmc@lists.ozlabs.org, sven@svenpeter.dev,
linux-i2c@vger.kernel.org, tali.perry@nuvoton.com,
robh+dt@kernel.org, benjaminfair@google.com,
tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, olof@lixom.net,
wsa@kernel.org, kfting@nuvoton.com, avifishman70@gmail.com,
yangyicong@hisilicon.com, bence98@sch.bme.hu,
christophe.leroy@csgroup.eu, venture@google.com,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845
Date: Mon, 21 Feb 2022 16:31:37 +0800 [thread overview]
Message-ID: <CACD3sJaC-8BO9TkunmAfFQOow1rmWxEjhSRE-kekFRM1wmKq2Q@mail.gmail.com> (raw)
In-Reply-To: <1645410969.402841.2041548.nullmailer@robh.at.kernel.org>
Hi Rob:
Thank you for your comments and they will be addressed.
Rob Herring <robh@kernel.org> 於 2022年2月21日 週一 上午10:36寫道:
>
> On Sun, 20 Feb 2022 11:53:12 +0800, Tyrone Ting wrote:
> > From: Tyrone Ting <kfting@nuvoton.com>
> >
> > Add compatible and nuvoton,sys-mgr description for NPCM i2c module.
> >
> > Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> > Signed-off-by: Tali Perry <tali.perry1@gmail.com>
> > ---
> > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++-----
> > 1 file changed, 12 insertions(+), 5 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:19:6: [warning] wrong indentation: expected 4 but found 5 (indentation)
> ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:20:7: [warning] wrong indentation: expected 7 but found 6 (indentation)
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1595125
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Best regards,
Tyrone
next prev parent reply other threads:[~2022-02-21 8:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 3:53 [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 01/11] arm: dts: add new property for NPCM i2c module Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 02/11] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-02-21 2:36 ` Rob Herring
2022-02-21 8:31 ` Tyrone Ting [this message]
2022-02-22 17:56 ` Rob Herring
2022-02-23 3:41 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 03/11] i2c: npcm: Fix client address calculation Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 04/11] i2c: npcm: Update gcr property name Tyrone Ting
2022-02-20 9:32 ` Krzysztof Kozlowski
2022-02-21 8:29 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 05/11] i2c: npcm: Remove unused clock node Tyrone Ting
2022-02-21 11:49 ` Jonathan Neuschäfer
2022-02-22 2:15 ` Tyrone Ting
2022-02-22 15:58 ` Jonathan Neuschäfer
2022-02-23 3:38 ` Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 06/11] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 07/11] i2c: npcm: Add tx complete counter Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 08/11] i2c: npcm: Correct register access width Tyrone Ting
2022-02-21 11:55 ` Jonathan Neuschäfer
2022-02-20 3:53 ` [PATCH v2 09/11] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 10/11] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-02-20 3:53 ` [PATCH v2 11/11] i2c: npcm: Support NPCM845 Tyrone Ting
2022-02-20 9:36 ` Krzysztof Kozlowski
2022-02-21 8:33 ` Tyrone Ting
2022-02-20 9:30 ` [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Krzysztof Kozlowski
2022-02-21 8:16 ` Tyrone Ting
2022-02-21 8:32 ` Krzysztof Kozlowski
2022-02-21 8:47 ` Tyrone Ting
2022-03-01 19:45 ` Wolfram Sang
2022-03-02 12:53 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACD3sJaC-8BO9TkunmAfFQOow1rmWxEjhSRE-kekFRM1wmKq2Q@mail.gmail.com \
--to=warp5tw@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=bence98@sch.bme.hu \
--cc=benjaminfair@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jie.deng@intel.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).