* [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
@ 2023-01-27 19:21 Bartosz Golaszewski
2023-01-27 19:56 ` Krzysztof Kozlowski
2023-02-09 4:22 ` Bjorn Andersson
0 siblings, 2 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-01-27 19:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add a compatible for the sa8775p platform's Secure Channel Manager
firmware interface.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index 4193492ba73e..fd3c787e44a8 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -39,6 +39,7 @@ properties:
- qcom,scm-msm8996
- qcom,scm-msm8998
- qcom,scm-qdu1000
+ - qcom,scm-sa8775p
- qcom,scm-sc7180
- qcom,scm-sc7280
- qcom,scm-sc8280xp
--
2.37.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-01-27 19:21 [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible Bartosz Golaszewski
@ 2023-01-27 19:56 ` Krzysztof Kozlowski
2023-01-27 21:22 ` Bartosz Golaszewski
2023-02-09 4:22 ` Bjorn Andersson
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-27 19:56 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Bartosz Golaszewski
On 27/01/2023 20:21, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a compatible for the sa8775p platform's Secure Channel Manager
> firmware interface.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
> 1 file changed, 1 insertion(+)
If you send bindings separately from DTS (which is fine), please provide
the link to the user - either DTS or driver for this compatible. Driver
does not use it, thus to the DTS.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-01-27 19:56 ` Krzysztof Kozlowski
@ 2023-01-27 21:22 ` Bartosz Golaszewski
2023-01-28 10:13 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-01-27 21:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 27/01/2023 20:21, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add a compatible for the sa8775p platform's Secure Channel Manager
> > firmware interface.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> If you send bindings separately from DTS (which is fine), please provide
> the link to the user - either DTS or driver for this compatible. Driver
> does not use it, thus to the DTS.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Can you specify what kind of link you're expecting? I'm looking at
previous commits for this file and not seeing anything. There's no
upstream user of this compatible in any DTS yet.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-01-27 21:22 ` Bartosz Golaszewski
@ 2023-01-28 10:13 ` Krzysztof Kozlowski
2023-01-28 11:22 ` Bartosz Golaszewski
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-28 10:13 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On 27/01/2023 22:22, Bartosz Golaszewski wrote:
> On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 27/01/2023 20:21, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Add a compatible for the sa8775p platform's Secure Channel Manager
>>> firmware interface.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> If you send bindings separately from DTS (which is fine), please provide
>> the link to the user - either DTS or driver for this compatible. Driver
>> does not use it, thus to the DTS.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Can you specify what kind of link you're expecting? I'm looking at
> previous commits for this file and not seeing anything. There's no
> upstream user of this compatible in any DTS yet.
I expect lore link to the patchset you sent using this binding, so we
can verify whether you used it correctly or not. If people were testing
their DTS against bindings they write, this would not be needed.
Unfortunately people do not do that...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-01-28 10:13 ` Krzysztof Kozlowski
@ 2023-01-28 11:22 ` Bartosz Golaszewski
0 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-01-28 11:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On Sat, Jan 28, 2023 at 11:13 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 27/01/2023 22:22, Bartosz Golaszewski wrote:
> > On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 27/01/2023 20:21, Bartosz Golaszewski wrote:
> >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >>>
> >>> Add a compatible for the sa8775p platform's Secure Channel Manager
> >>> firmware interface.
> >>>
> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >>> ---
> >>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>
> >> If you send bindings separately from DTS (which is fine), please provide
> >> the link to the user - either DTS or driver for this compatible. Driver
> >> does not use it, thus to the DTS.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >
> > Can you specify what kind of link you're expecting? I'm looking at
> > previous commits for this file and not seeing anything. There's no
> > upstream user of this compatible in any DTS yet.
>
>
> I expect lore link to the patchset you sent using this binding, so we
> can verify whether you used it correctly or not. If people were testing
> their DTS against bindings they write, this would not be needed.
> Unfortunately people do not do that...
>
Touché. I am making sure v2 passes dtbs_check though. :)
v1 didn't have this compatible and used the fallback directly, hence
this patch being sent before v2. There's no link yet, as I'm still
polishing the dts for sa8775p-ride. Will remember to add one in the
future.
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-01-27 19:21 [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible Bartosz Golaszewski
2023-01-27 19:56 ` Krzysztof Kozlowski
@ 2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 10:23 ` Bartosz Golaszewski
1 sibling, 1 reply; 7+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:22 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Rob Herring, Konrad Dybcio,
Krzysztof Kozlowski
Cc: linux-kernel, Bartosz Golaszewski, linux-arm-msm, devicetree
On Fri, 27 Jan 2023 20:21:39 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a compatible for the sa8775p platform's Secure Channel Manager
> firmware interface.
>
>
Applied, thanks!
[1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
commit: 27d71e8063d99b4429832bc52de171ace6b1e562
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
2023-02-09 4:22 ` Bjorn Andersson
@ 2023-02-09 10:23 ` Bartosz Golaszewski
0 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2023-02-09 10:23 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Bartosz Golaszewski, Andy Gross, Rob Herring, Konrad Dybcio,
Krzysztof Kozlowski, linux-kernel, linux-arm-msm, devicetree
On Thu, 9 Feb 2023 at 05:21, Bjorn Andersson <andersson@kernel.org> wrote:
>
> On Fri, 27 Jan 2023 20:21:39 +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add a compatible for the sa8775p platform's Secure Channel Manager
> > firmware interface.
> >
> >
>
> Applied, thanks!
>
> [1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible
> commit: 27d71e8063d99b4429832bc52de171ace6b1e562
>
> Best regards,
> --
> Bjorn Andersson <andersson@kernel.org>
Bjorn,
FYI I resent this patch as part of an integration series later[1] as
per Krzysztof's suggestion. Could you pick the entire thing up too?
Thanks!
Bart
[1] https://lore.kernel.org/linux-arm-msm/20230201152038.203387-1-brgl@bgdev.pl/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-09 10:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-27 19:21 [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible Bartosz Golaszewski
2023-01-27 19:56 ` Krzysztof Kozlowski
2023-01-27 21:22 ` Bartosz Golaszewski
2023-01-28 10:13 ` Krzysztof Kozlowski
2023-01-28 11:22 ` Bartosz Golaszewski
2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 10:23 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).