From: Joel Stanley <joel@jms.id.au>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-clk@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v5 6/6] dt-bindings: clock: ast2600: Expand comment on reset definitions
Date: Thu, 2 Mar 2023 03:27:44 +0000 [thread overview]
Message-ID: <CACPK8Xcd5XyLc3aO2nUXWFMAZnEdooBE=z_qj6H6d+vfOrnSug@mail.gmail.com> (raw)
In-Reply-To: <20230302005834.13171-7-jk@codeconstruct.com.au>
On Thu, 2 Mar 2023 at 00:58, Jeremy Kerr <jk@codeconstruct.com.au> wrote:
>
> The current "not part of a gate" is a little ambiguous. Expand this a
> little to clarify the reference to the paired clock + reset control.
This confuses me, but if you think it helps then that's good.
Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> ---
> include/dt-bindings/clock/ast2600-clock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index b4d69103d722..e149eee61588 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -87,7 +87,7 @@
> #define ASPEED_CLK_MAC4RCLK 70
> #define ASPEED_CLK_I3C 71
>
> -/* Only list resets here that are not part of a gate */
> +/* Only list resets here that are not part of a clock gate + reset pair */
> #define ASPEED_RESET_ADC 55
> #define ASPEED_RESET_JTAG_MASTER2 54
> #define ASPEED_RESET_I3C_DMA 39
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-03-02 3:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 0:58 [PATCH v5 0/6] Add definitions for AST2600 i3c clocks Jeremy Kerr
2023-03-02 0:58 ` [PATCH v5 1/6] clk: ast2600: allow empty entries in aspeed_g6_gates Jeremy Kerr
2023-03-06 22:18 ` Stephen Boyd
2023-03-02 0:58 ` [PATCH v5 2/6] dt-bindings: clock: ast2600: Add top-level I3C clock Jeremy Kerr
2023-03-06 22:18 ` Stephen Boyd
2023-03-02 0:58 ` [PATCH v5 3/6] clk: ast2600: Add full configs for I3C clocks Jeremy Kerr
2023-03-02 3:23 ` Joel Stanley
2023-03-06 22:18 ` Stephen Boyd
2023-03-02 0:58 ` [PATCH v5 4/6] dt-bindings: clock: ast2600: remove IC36 & I3C7 clock definitions Jeremy Kerr
2023-03-06 22:18 ` Stephen Boyd
2023-03-02 0:58 ` [PATCH v5 5/6] clk: ast2600: Add comment about combined clock + reset handling Jeremy Kerr
2023-03-02 3:30 ` Joel Stanley
2023-03-06 22:18 ` Stephen Boyd
2023-03-02 0:58 ` [PATCH v5 6/6] dt-bindings: clock: ast2600: Expand comment on reset definitions Jeremy Kerr
2023-03-02 3:27 ` Joel Stanley [this message]
2023-03-02 7:35 ` Krzysztof Kozlowski
2023-03-06 22:19 ` Stephen Boyd
2023-03-02 4:37 ` [PATCH v5 0/6] Add definitions for AST2600 i3c clocks Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xcd5XyLc3aO2nUXWFMAZnEdooBE=z_qj6H6d+vfOrnSug@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=jk@codeconstruct.com.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).