From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,WEIRD_QUOTING autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5EA2C352A4 for ; Mon, 10 Feb 2020 02:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC7F220870 for ; Mon, 10 Feb 2020 02:29:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="Vot3Gk5r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgBJC3c (ORCPT ); Sun, 9 Feb 2020 21:29:32 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:37687 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbgBJC3c (ORCPT ); Sun, 9 Feb 2020 21:29:32 -0500 Received: by mail-qt1-f195.google.com with SMTP id w47so4078604qtk.4; Sun, 09 Feb 2020 18:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ra0rpldUyx5dQ3cALlEVBxf6hudJtV4wQ0FpwYENXlc=; b=Vot3Gk5rrSJb99S4ur/g2DWtP16aRkPxY1kmM1/eWqxjFECGCtYqTEfCzE71cF8MJG Y8LpDwico/I/Z9X30DRHGnLWHSQ3F0DIY8zQzeXMy96PomCYJbtqiwlt7ayxu3I2sfqA Kz21kD/8LnuRhDY+yWY+iYnwPcnR++Pbyz6k8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ra0rpldUyx5dQ3cALlEVBxf6hudJtV4wQ0FpwYENXlc=; b=BxyfwYYmBNNQxcPNcscB6BAmXXW+w9INLo0juQYnTlCmknnsbR7TT/k2XgPx/6/Rbp EF+0ztuo08lfw29dkCYuWMnk+pyAYSJyhk51VZErMSuXtzivcdvRYkaY4Yk1C72ycWbm 4BuOMs9D/3CkTRPnyPop90nvYNO+AHCOaTVJ9WWACKPzut5ngEoqwycQ2M/AL2PNkyGU DM++y6Q9QTNh1xlWS1xuwSWha8Q0cdlBiwc0GIWRAI9U4nfdBdP8WXShvIhSW/iMIW/J zzcPKJZuUCD9f3bAEIbDwq7I2usMsT/d1a4jJ8iaurgxTrvfMsvioLz+5ORWP5vL765j lcPg== X-Gm-Message-State: APjAAAWQGaVVfmF2To6jC+DG5BG5vfdm71H6dctcwoK8N5142jPpB1ZQ x8Mg9o5t6gtmaSOOwK1Obv5JpF7MPXb6ROec8y8= X-Google-Smtp-Source: APXvYqzcGvgfoldOPlRF0oV/3hA3tC1aE/eu4yDH5GYf9atHD8eepmRE6qo+l9/K1/ie+5Ux+ddb5DSELZ856Ev5PVU= X-Received: by 2002:ac8:6b53:: with SMTP id x19mr2941384qts.220.1581301770229; Sun, 09 Feb 2020 18:29:30 -0800 (PST) MIME-Version: 1.0 References: <20200206170234.84288-1-geissonator@gmail.com> In-Reply-To: <20200206170234.84288-1-geissonator@gmail.com> From: Joel Stanley Date: Mon, 10 Feb 2020 02:29:19 +0000 Message-ID: Subject: Re: [PATCH v3] ARM: dts: aspeed: witherspoon: Add gpio line names To: Andrew Geissler Cc: OpenBMC Maillist , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Andrew Geissler , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 6 Feb 2020 at 17:03, Andrew Geissler wrote: > > From: Andrew Geissler > > Name the GPIOs to help userspace work with them. The names describe the > functionality the lines provide, not the net or ball name. This makes it > easier to share userspace code across different systems and makes the > use of the lines more obvious. > > Signed-off-by: Andrew Geissler Reviewed-by: Joel Stanley I will wait for Andrew before merging, but this looks good to me. > --- > v3: added more detail to commit message > removed linux dev-5.4 from PATCH header > removed redundant status from gpio > removed blank line > v2: added upstream to patch > prepended fsi- on fsi related gpios > prepended led- on led related gpios > prepended presence on presence related gpios > dropped pin_gpio_a1 definition > --- > .../boot/dts/aspeed-bmc-opp-witherspoon.dts | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > index 515f0f208ee6..2269c73b8987 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > @@ -193,6 +193,40 @@ > > }; > > +&gpio { > + gpio-line-names = > + /*A0-A7*/ "","cfam-reset","","","","","fsi-mux","", > + /*B0-B7*/ "","","","","","air-water","","", > + /*C0-C7*/ "","","","","","","","", > + /*D0-D7*/ "fsi-enable","","","","","","","", > + /*E0-E7*/ "fsi-data","","","","","","","", > + /*F0-F7*/ "","","","","","","","", > + /*G0-G7*/ "","","","","","","","", > + /*H0-H7*/ "","","","","","","","", > + /*I0-I7*/ "","","","","","","","", > + /*J0-J7*/ "","","checkstop","","","","","", > + /*K0-K7*/ "","","","","","","","", > + /*L0-L7*/ "","","","","","","","", > + /*M0-M7*/ "","","","","","","","", > + /*N0-N7*/ "presence-ps1","","led-rear-fault","led-rear-power", > + "led-rear-id","","","", > + /*O0-O7*/ "","","","","","","","", > + /*P0-P7*/ "","","","","","","","presence-ps0", > + /*Q0-Q7*/ "","","","","","","","", > + /*R0-R7*/ "","","fsi-trans","","","power-button","","", > + /*S0-S7*/ "","","","","","","","", > + /*T0-T7*/ "","","","","","","","", > + /*U0-U7*/ "","","","","","","","", > + /*V0-V7*/ "","","","","","","","", > + /*W0-W7*/ "","","","","","","","", > + /*X0-X7*/ "","","","","","","","", > + /*Y0-Y7*/ "","","","","","","","", > + /*Z0-Z7*/ "","","","","","","","", > + /*AA0-AA7*/ "fsi-clock","","","","","","","", > + /*AB0-AB7*/ "","","","","","","","", > + /*AC0-AC7*/ "","","","","","","",""; > +}; > + > &fmc { > status = "okay"; > > -- > 2.21.0 (Apple Git-122) >