From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Stanley Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Fix 'compatible' schema errors Date: Mon, 15 Jul 2019 23:16:54 +0000 Message-ID: References: <20190715223725.12924-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190715223725.12924-1-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: devicetree , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Linus Walleij , linux-gpio@vger.kernel.org, Linux ARM List-Id: devicetree@vger.kernel.org On Mon, 15 Jul 2019 at 22:37, Rob Herring wrote: > > The Aspeed pinctl schema have errors in the 'compatible' schema: > > Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml: \ > properties:compatible:enum: ['aspeed', 'ast2400-pinctrl', 'aspeed', 'g4-pinctrl'] has non-unique elements > Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml: \ > properties:compatible:enum: ['aspeed', 'ast2500-pinctrl', 'aspeed', 'g5-pinctrl'] has non-unique elements > > Flow style sequences have to be quoted if the vales contain ','. Fix > this by using the more common one line per entry formatting. > > properties: > compatible: > - enum: [ aspeed,ast2400-pinctrl, aspeed,g4-pinctrl ] > + enum: > + - aspeed,ast2400-pinctrl > + - aspeed,g4-pinctrl Thanks for the fix. However, we've standardised on the first form for all of our device trees, so we can drop the second compatible string from the bindings. I think Andrew already has a patch cooking to do this. Cheers, Joel