From: Joel Stanley <joel@jms.id.au>
To: Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding
Date: Wed, 28 Oct 2020 05:32:43 +0000 [thread overview]
Message-ID: <CACPK8XeO2Cin2bNkjoHz-oK22mRb0LBHSYRTtd56r5trmihP-g@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XcgKTEEfPL54Spd_AQTdJVm=xt+rqbteaYygLQw-GKRcQ@mail.gmail.com>
On Wed, 28 Oct 2020 at 05:25, Joel Stanley <joel@jms.id.au> wrote:
>
> On Tue, 27 Oct 2020 at 12:38, Konstantin Aladyshev
> <aladyshev22@gmail.com> wrote:
> >
> > KCS nodes compatible property in the 'aspeed-g5.dtsi' file was
> > changed to use v2 binding in the commit fa4c8ec6feaa
> > ("ARM: dts: aspeed: Change KCS nodes to v2 binding").
> > For the proper initialization of /dev/ipmi-kcs* devices
> > KCS node variables also need to be changed to use v2 binding.
> >
> > Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
>
> Fixes: 09f5f680707e ("ipmi: kcs: aspeed: Implement v2 bindings")
Actually, this is probably better:
Fixes: fa4c8ec6feaa ("ARM: dts: aspeed: Change KCS nodes to v2 binding")
I slightly reworked your commit message when applying.
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > index 60ba86f3e5bc..89ddc3847222 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> > @@ -139,17 +139,17 @@
> >
> > &kcs1 {
> > status = "okay";
> > - kcs_addr = <0x60>;
> > + aspeed,lpc-io-reg = <0x60>;
> > };
> >
> > &kcs2 {
> > status = "okay";
> > - kcs_addr = <0x62>;
> > + aspeed,lpc-io-reg = <0x62>;
> > };
> >
> > &kcs4 {
> > status = "okay";
> > - kcs_addr = <0x97DE>;
> > + aspeed,lpc-io-reg = <0x97DE>;
> > };
> >
> > &lpc_snoop {
> > --
> > 2.17.1
> >
prev parent reply other threads:[~2020-10-29 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 12:37 [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding Konstantin Aladyshev
2020-10-27 12:37 ` [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3 Konstantin Aladyshev
2020-10-28 5:28 ` Joel Stanley
2020-10-28 15:59 ` Supreeth Venkatesh
2020-10-27 12:37 ` [PATCH 3/3] ARM: dts: aspeed: amd-ethanolx: Enable devices for the iKVM functionality Konstantin Aladyshev
2020-10-27 14:02 ` Supreeth Venkatesh
2020-10-28 5:28 ` Joel Stanley
2020-10-27 14:09 ` [PATCH 1/3] ARM: dts: aspeed: amd-ethanolx: Update KCS nodes to use v2 binding Supreeth Venkatesh
2020-10-27 21:00 ` Konstantin Aladyshev
2020-10-28 9:50 ` Joel Stanley
2020-10-28 5:25 ` Joel Stanley
2020-10-28 5:32 ` Joel Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XeO2Cin2bNkjoHz-oK22mRb0LBHSYRTtd56r5trmihP-g@mail.gmail.com \
--to=joel@jms.id.au \
--cc=aladyshev22@gmail.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=supreeth.venkatesh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).